2023-02-10 09:41:15

by Herbert Xu

[permalink] [raw]
Subject: [PATCH] crypto: aspeed - Fix modular aspeed-acry

When aspeed-acry is enabled as a module it doesn't get built at
all. Fix this by adding it to obj-m.

Signed-off-by: Herbert Xu <[email protected]>

diff --git a/drivers/crypto/aspeed/Makefile b/drivers/crypto/aspeed/Makefile
index 24284d812b79..15862752c053 100644
--- a/drivers/crypto/aspeed/Makefile
+++ b/drivers/crypto/aspeed/Makefile
@@ -6,4 +6,6 @@ aspeed_crypto-objs := aspeed-hace.o \
$(hace-hash-y) \
$(hace-crypto-y)

-obj-$(CONFIG_CRYPTO_DEV_ASPEED_ACRY) += aspeed-acry.o
+aspeed_acry-$(CONFIG_CRYPTO_DEV_ASPEED_ACRY) += aspeed-acry.o
+
+obj-$(CONFIG_CRYPTO_DEV_ASPEED) += $(aspeed_acry-y)
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


2023-02-13 01:48:49

by Neal Liu

[permalink] [raw]
Subject: RE: [PATCH] crypto: aspeed - Fix modular aspeed-acry

> When aspeed-acry is enabled as a module it doesn't get built at all. Fix this
> by adding it to obj-m.
>
> Signed-off-by: Herbert Xu <[email protected]>

Reviewed-by: Neal Liu <[email protected]>

> diff --git a/drivers/crypto/aspeed/Makefile b/drivers/crypto/aspeed/Makefile
> index 24284d812b79..15862752c053 100644
> --- a/drivers/crypto/aspeed/Makefile
> +++ b/drivers/crypto/aspeed/Makefile
> @@ -6,4 +6,6 @@ aspeed_crypto-objs := aspeed-hace.o \
> $(hace-hash-y) \
> $(hace-crypto-y)
>
> -obj-$(CONFIG_CRYPTO_DEV_ASPEED_ACRY) += aspeed-acry.o
> +aspeed_acry-$(CONFIG_CRYPTO_DEV_ASPEED_ACRY) += aspeed-acry.o
> +
> +obj-$(CONFIG_CRYPTO_DEV_ASPEED) += $(aspeed_acry-y)
> --
> Email: Herbert Xu <[email protected]> Home Page:
> http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt