2021-06-22 15:19:46

by Colin King

Subject: [PATCH] crypto: qat: ratelimit invalid ioctl message and print the invalid cmd

From: Colin Ian King <[email protected]>

Currently incorrect QAT ioctls can spam the kernel log with error messages
of the form "QAT: Invalid ioctl" if a userspace program uses the wrong
ioctl command. Quench the messages by ratelimiting them and also print
the invalid command being used as that is useful to know.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/crypto/qat/qat_common/adf_ctl_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/qat/qat_common/adf_ctl_drv.c b/drivers/crypto/qat/qat_common/adf_ctl_drv.c
index 96b437bfe3de..6f64aa693146 100644
--- a/drivers/crypto/qat/qat_common/adf_ctl_drv.c
+++ b/drivers/crypto/qat/qat_common/adf_ctl_drv.c
@@ -406,7 +406,7 @@ static long adf_ctl_ioctl(struct file *fp, unsigned int cmd, unsigned long arg)
ret = adf_ctl_ioctl_get_status(fp, cmd, arg);
break;
default:
- pr_err("QAT: Invalid ioctl\n");
+ pr_err_ratelimited("QAT: Invalid ioctl %d\n", cmd);
ret = -EFAULT;
break;
}
--
2.31.1

2021-06-23 14:10:07

by Cabiddu, Giovanni

Subject: Re: [PATCH] crypto: qat: ratelimit invalid ioctl message and print the invalid cmd

On Tue, Jun 22, 2021 at 04:16:08PM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Currently incorrect QAT ioctls can spam the kernel log with error messages
> of the form "QAT: Invalid ioctl" if a userspace program uses the wrong
> ioctl command. Quench the messages by ratelimiting them and also print
> the invalid command being used as that is useful to know.
>
> Signed-off-by: Colin Ian King <[email protected]>
Just a minor comment on the commit message:
crypto: qat: ratelimit invalid ioctl message and print
^
Patches to the qat driver have the following headline:
crypto: qat -
not
crypto: qat:


Apart from that
Acked-by: Giovanni Cabiddu <[email protected]>

Regards,

--
Giovanni