2022-02-11 10:17:33

by Cabiddu, Giovanni

[permalink] [raw]
Subject: Re: [PATCH 0/3] Introduce support for QAT Dynamic Power Management

Hi Herbert,

On Fri, Feb 11, 2022 at 08:35:34PM +1100, Herbert Xu wrote:
> On Thu, Feb 03, 2022 at 01:54:31PM +0000, Wojciech Ziemba wrote:
> > This patch set consist of following updates:
> > 1. Add misc workqueue for general purpose usage.
> > 2. Move error source related CSRs from 4xxx to the wider GEN4 header
> > file.
> > 3. Add support for HW QAT Power Management (PM) feature.
> > This feature is enabled at init time (1) by sending an admin
> > message to
> > the firmware, targeting the admin AE, that sets the idle time
> > before
> > the device changes state and (2) by unmasking the PM source of
> > interrupt in ERRMSK2.
> >
> > The interrupt handler is extended to handle a PM interrupt which
> > is triggered by HW when a PM transition occurs. In this case,
> > the
> > driver responds acknowledging the transaction using the HOST_MSG
> > mailbox.
> >
> >
> > Wojciech Ziemba (3):
> > crypto: qat - add misc workqueue
> > crypto: qat - move and rename GEN4 error register definitions
> > crypto: qat - enable power management for QAT GEN4
> >
> > .../crypto/qat/qat_4xxx/adf_4xxx_hw_data.c | 21 +--
> > .../crypto/qat/qat_4xxx/adf_4xxx_hw_data.h | 24 ---
> > drivers/crypto/qat/qat_common/Makefile | 1 +
> > .../crypto/qat/qat_common/adf_accel_devices.h | 2 +
> > drivers/crypto/qat/qat_common/adf_admin.c | 37 +++++
> > .../crypto/qat/qat_common/adf_common_drv.h | 4 +
> > drivers/crypto/qat/qat_common/adf_ctl_drv.c | 6 +
> > .../crypto/qat/qat_common/adf_gen4_hw_data.h | 14 ++
> > drivers/crypto/qat/qat_common/adf_gen4_pm.c | 137 ++++++++++++++++++
> > drivers/crypto/qat/qat_common/adf_gen4_pm.h | 44 ++++++
> > drivers/crypto/qat/qat_common/adf_init.c | 6 +
> > drivers/crypto/qat/qat_common/adf_isr.c | 42 ++++++
> > .../qat/qat_common/icp_qat_fw_init_admin.h | 1 +
> > 13 files changed, 306 insertions(+), 33 deletions(-)
> > create mode 100644 drivers/crypto/qat/qat_common/adf_gen4_pm.c
> > create mode 100644 drivers/crypto/qat/qat_common/adf_gen4_pm.h
>
> All applied. Thanks.
I think this set needs to be reverted. Wojciech provided a v2 that fixed
a few regressions.

Thanks,

--
Giovanni