2023-07-27 08:21:51

by Herbert Xu

Subject: Re: [PATCH] crypto: all - alloc and init all req alloc as zero

On Thu, Jul 27, 2023 at 04:05:48PM +0800, Zhang Yiqun wrote:
> This patch is to change all req struct alloc function from kmalloc
> to kzalloc. Sometimes, it will incur some errors without initialized
> zero.
>
> Signed-off-by: Zhang Yiqun <[email protected]>
> ---
> include/crypto/akcipher.h | 2 +-
> include/crypto/hash.h | 2 +-
> include/crypto/kpp.h | 2 +-
> include/crypto/skcipher.h | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)

Nack. Unless you have a specific issue please don't submit vague
patches like this. You should always state what issue led you to
make a change like this.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2023-07-28 09:15:40

by Zhang Yiqun

Subject: Re: Re: [PATCH] crypto: all - alloc and init all req alloc as zero

Actually, I met a problem in my own development. Because some members in req
struct is not intialized, they cause some errors in test. If we change kmalloc
to kzalloc, it can facilitate all developers to care about inialized all
members. I hope my idea can convince you. But I think you have other
important consideration.

Thanks,

> -----Original Messages-----
> From: "Herbert Xu" <[email protected]>
> Send time:Thursday, 07/27/2023 16:07:50
> To: "Zhang Yiqun" <[email protected]>
> Cc: [email protected], [email protected], [email protected]
> Subject: Re: [PATCH] crypto: all - alloc and init all req alloc as zero
>
> On Thu, Jul 27, 2023 at 04:05:48PM +0800, Zhang Yiqun wrote:
> > This patch is to change all req struct alloc function from kmalloc
> > to kzalloc. Sometimes, it will incur some errors without initialized
> > zero.
> >
> > Signed-off-by: Zhang Yiqun <[email protected]>
> > ---
> > include/crypto/akcipher.h | 2 +-
> > include/crypto/hash.h | 2 +-
> > include/crypto/kpp.h | 2 +-
> > include/crypto/skcipher.h | 2 +-
> > 4 files changed, 4 insertions(+), 4 deletions(-)
>
> Nack. Unless you have a specific issue please don't submit vague
> patches like this. You should always state what issue led you to
> make a change like this.
>
> Thanks,
> --
> Email: Herbert Xu <[email protected]>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



信息安全声明：本邮件包含信息归发件人所在组织所有,发件人所在组织对该邮件拥有所有权利。请接收者注意保密,未经发件人书面许可,不得向任何第三方组织和个人透露本邮件所含信息。
Information Security Notice: The information contained in this mail is solely property of the sender's organization.This mail communication is confidential.Recipients named above are obligated to maintain secrecy and are not permitted to disclose the contents of this communication to others.