2022-09-23 09:41:32

by Shang XiaoJing

Subject: [PATCH -next] crypto: aspeed - Remove redundant dev_err call

devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.

Signed-off-by: Shang XiaoJing <[email protected]>
---
drivers/crypto/aspeed/aspeed-hace.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/crypto/aspeed/aspeed-hace.c b/drivers/crypto/aspeed/aspeed-hace.c
index 3f880aafb6a2..e05c32c31842 100644
--- a/drivers/crypto/aspeed/aspeed-hace.c
+++ b/drivers/crypto/aspeed/aspeed-hace.c
@@ -123,10 +123,8 @@ static int aspeed_hace_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, hace_dev);

hace_dev->regs = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(hace_dev->regs)) {
- dev_err(&pdev->dev, "Failed to map resources\n");
+ if (IS_ERR(hace_dev->regs))
return PTR_ERR(hace_dev->regs);
- }

/* Get irq number and register it */
hace_dev->irq = platform_get_irq(pdev, 0);
--
2.17.1

2022-09-23 10:25:49

by Neal Liu

Subject: RE: [PATCH -next] crypto: aspeed - Remove redundant dev_err call

> devm_ioremap_resource() prints error message in itself. Remove the dev_err
> call to avoid redundant error message.
>
> Signed-off-by: Shang XiaoJing <[email protected]>
> ---
> drivers/crypto/aspeed/aspeed-hace.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/aspeed/aspeed-hace.c
> b/drivers/crypto/aspeed/aspeed-hace.c
> index 3f880aafb6a2..e05c32c31842 100644
> --- a/drivers/crypto/aspeed/aspeed-hace.c
> +++ b/drivers/crypto/aspeed/aspeed-hace.c
> @@ -123,10 +123,8 @@ static int aspeed_hace_probe(struct platform_device
> *pdev)
> platform_set_drvdata(pdev, hace_dev);
>
> hace_dev->regs = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(hace_dev->regs)) {
> - dev_err(&pdev->dev, "Failed to map resources\n");
> + if (IS_ERR(hace_dev->regs))
> return PTR_ERR(hace_dev->regs);
> - }
>
> /* Get irq number and register it */
> hace_dev->irq = platform_get_irq(pdev, 0);
> --
> 2.17.1

Similar patch just be proposed few days ago.
https://patchwork.kernel.org/project/linux-crypto/patch/[email protected]/

2022-09-23 12:40:20

by Shang XiaoJing

Subject: Re: [PATCH -next] crypto: aspeed - Remove redundant dev_err call

On 2022/9/23 18:15, Neal Liu wrote:
>> devm_ioremap_resource() prints error message in itself. Remove the dev_err
>> call to avoid redundant error message.
>>
>> Signed-off-by: Shang XiaoJing <[email protected]>
>> ---
>> drivers/crypto/aspeed/aspeed-hace.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/crypto/aspeed/aspeed-hace.c
>> b/drivers/crypto/aspeed/aspeed-hace.c
>> index 3f880aafb6a2..e05c32c31842 100644
>> --- a/drivers/crypto/aspeed/aspeed-hace.c
>> +++ b/drivers/crypto/aspeed/aspeed-hace.c
>> @@ -123,10 +123,8 @@ static int aspeed_hace_probe(struct platform_device
>> *pdev)
>> platform_set_drvdata(pdev, hace_dev);
>>
>> hace_dev->regs = devm_ioremap_resource(&pdev->dev, res);
>> - if (IS_ERR(hace_dev->regs)) {
>> - dev_err(&pdev->dev, "Failed to map resources\n");
>> + if (IS_ERR(hace_dev->regs))
>> return PTR_ERR(hace_dev->regs);
>> - }
>>
>> /* Get irq number and register it */
>> hace_dev->irq = platform_get_irq(pdev, 0);
>> --
>> 2.17.1
> Similar patch just be proposed few days ago.
> https://patchwork.kernel.org/project/linux-crypto/patch/[email protected]/

sorry, pls ignore mine.


Thanks,

Shang XiaoJing

2022-09-30 05:59:41

by Herbert Xu

Subject: Re: [PATCH -next] crypto: aspeed - Remove redundant dev_err call

On Fri, Sep 23, 2022 at 08:26:21PM +0800, shangxiaojing wrote:
>
> On 2022/9/23 18:15, Neal Liu wrote:
> > > devm_ioremap_resource() prints error message in itself. Remove the dev_err
> > > call to avoid redundant error message.
> > >
> > > Signed-off-by: Shang XiaoJing <[email protected]>
> > > ---
> > > drivers/crypto/aspeed/aspeed-hace.c | 4 +---
> > > 1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/crypto/aspeed/aspeed-hace.c
> > > b/drivers/crypto/aspeed/aspeed-hace.c
> > > index 3f880aafb6a2..e05c32c31842 100644
> > > --- a/drivers/crypto/aspeed/aspeed-hace.c
> > > +++ b/drivers/crypto/aspeed/aspeed-hace.c
> > > @@ -123,10 +123,8 @@ static int aspeed_hace_probe(struct platform_device
> > > *pdev)
> > > platform_set_drvdata(pdev, hace_dev);
> > >
> > > hace_dev->regs = devm_ioremap_resource(&pdev->dev, res);
> > > - if (IS_ERR(hace_dev->regs)) {
> > > - dev_err(&pdev->dev, "Failed to map resources\n");
> > > + if (IS_ERR(hace_dev->regs))
> > > return PTR_ERR(hace_dev->regs);
> > > - }
> > >
> > > /* Get irq number and register it */
> > > hace_dev->irq = platform_get_irq(pdev, 0);
> > > --
> > > 2.17.1
> > Similar patch just be proposed few days ago.
> > https://patchwork.kernel.org/project/linux-crypto/patch/[email protected]/
>
> sorry, pls ignore mine.

Actually I think these two patches are different and both can be
applied.

Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2022-09-30 06:20:05

by Herbert Xu

Subject: Re: [PATCH -next] crypto: aspeed - Remove redundant dev_err call

On Fri, Sep 23, 2022 at 06:01:59PM +0800, Shang XiaoJing wrote:
> devm_ioremap_resource() prints error message in itself. Remove the
> dev_err call to avoid redundant error message.
>
> Signed-off-by: Shang XiaoJing <[email protected]>
> ---
> drivers/crypto/aspeed/aspeed-hace.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt