2019-09-09 14:23:07

by Gustavo A. R. Silva

Subject: [PATCH] crypto: talitos - fix missing break in switch statement

Add missing break statement in order to prevent the code from falling
through to case CRYPTO_ALG_TYPE_AHASH.

Fixes: aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface")
Cc: [email protected]
Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/crypto/talitos.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
index c9d686a0e805..4818ae427098 100644
--- a/drivers/crypto/talitos.c
+++ b/drivers/crypto/talitos.c
@@ -3140,6 +3140,7 @@ static int talitos_remove(struct platform_device *ofdev)
break;
case CRYPTO_ALG_TYPE_AEAD:
crypto_unregister_aead(&t_alg->algt.alg.aead);
+ break;
case CRYPTO_ALG_TYPE_AHASH:
crypto_unregister_ahash(&t_alg->algt.alg.hash);
break;
--
2.23.0

2019-09-10 10:47:28

by Christophe Leroy

Subject: Re: [PATCH] crypto: talitos - fix missing break in switch statement

Le 09/09/2019 à 07:29, Gustavo A. R. Silva a écrit :
> Add missing break statement in order to prevent the code from falling
> through to case CRYPTO_ALG_TYPE_AHASH.
>
> Fixes: aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface")
> Cc: [email protected]
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Reviewed-by: Christophe Leroy <[email protected]>

> ---
> drivers/crypto/talitos.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
> index c9d686a0e805..4818ae427098 100644
> --- a/drivers/crypto/talitos.c
> +++ b/drivers/crypto/talitos.c
> @@ -3140,6 +3140,7 @@ static int talitos_remove(struct platform_device *ofdev)
> break;
> case CRYPTO_ALG_TYPE_AEAD:
> crypto_unregister_aead(&t_alg->algt.alg.aead);
> + break;
> case CRYPTO_ALG_TYPE_AHASH:
> crypto_unregister_ahash(&t_alg->algt.alg.hash);
> break;
>

2019-09-20 17:53:22

by Gustavo A. R. Silva

Subject: Re: [PATCH] crypto: talitos - fix missing break in switch statement

Hi all,

Friendly ping:

Who can take this?

Thanks
--
Gustavo

On 9/10/19 01:06, Christophe Leroy wrote:
>
>
> Le 09/09/2019 à 07:29, Gustavo A. R. Silva a écrit :
>> Add missing break statement in order to prevent the code from falling
>> through to case CRYPTO_ALG_TYPE_AHASH.
>>
>> Fixes: aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface")
>> Cc: [email protected]
>> Reported-by: kbuild test robot <[email protected]>
>> Signed-off-by: Gustavo A. R. Silva <[email protected]>
>
> Reviewed-by: Christophe Leroy <[email protected]>
>
>> ---
>>   drivers/crypto/talitos.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
>> index c9d686a0e805..4818ae427098 100644
>> --- a/drivers/crypto/talitos.c
>> +++ b/drivers/crypto/talitos.c
>> @@ -3140,6 +3140,7 @@ static int talitos_remove(struct platform_device *ofdev)
>>               break;
>>           case CRYPTO_ALG_TYPE_AEAD:
>>               crypto_unregister_aead(&t_alg->algt.alg.aead);
>> +            break;
>>           case CRYPTO_ALG_TYPE_AHASH:
>>               crypto_unregister_ahash(&t_alg->algt.alg.hash);
>>               break;
>>

2019-09-20 19:46:40

by Herbert Xu

Subject: Re: [PATCH] crypto: talitos - fix missing break in switch statement

On Mon, Sep 09, 2019 at 12:29:52AM -0500, Gustavo A. R. Silva wrote:
> Add missing break statement in order to prevent the code from falling
> through to case CRYPTO_ALG_TYPE_AHASH.
>
> Fixes: aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface")
> Cc: [email protected]
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/crypto/talitos.c | 1 +
> 1 file changed, 1 insertion(+)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt