2019-11-27 12:02:33

by Ard Biesheuvel

Subject: [PATCH] crypto: ccp: set max RSA modulus size for v3 platform devices as well

AMD Seattle incorporates a non-PCI version of the v3 CCP crypto
accelerator, and this version was left behind when the maximum
RSA modulus size was parameterized in order to support v5 hardware
which supports larger moduli than v3 hardware does. Due to this
oversight, RSA acceleration no longer works at all on these systems.

Fix this by setting the .rsamax property to the appropriate value
for v3 platform hardware.

Fixes: e28c190db66830c0 ("csrypto: ccp - Expand RSA support for a v5 ccp")
Cc: Gary R Hook <[email protected]>
Signed-off-by: Ard Biesheuvel <[email protected]>
---
drivers/crypto/ccp/ccp-dev-v3.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/ccp/ccp-dev-v3.c b/drivers/crypto/ccp/ccp-dev-v3.c
index 0186b3df4c87..0d5576f6ad21 100644
--- a/drivers/crypto/ccp/ccp-dev-v3.c
+++ b/drivers/crypto/ccp/ccp-dev-v3.c
@@ -586,6 +586,7 @@ const struct ccp_vdata ccpv3_platform = {
.setup = NULL,
.perform = &ccp3_actions,
.offset = 0,
+ .rsamax = CCP_RSA_MAX_WIDTH,
};

const struct ccp_vdata ccpv3 = {
--
2.20.1

2019-11-27 21:25:01

by Gary R Hook

Subject: Re: [PATCH] crypto: ccp: set max RSA modulus size for v3 platform devices as well

On 11/27/2019 6:01 AM, Ard Biesheuvel wrote:
> AMD Seattle incorporates a non-PCI version of the v3 CCP crypto
> accelerator, and this version was left behind when the maximum
> RSA modulus size was parameterized in order to support v5 hardware
> which supports larger moduli than v3 hardware does. Due to this
> oversight, RSA acceleration no longer works at all on these systems.
>
> Fix this by setting the .rsamax property to the appropriate value
> for v3 platform hardware.
>
> Fixes: e28c190db66830c0 ("csrypto: ccp - Expand RSA support for a v5 ccp")
> Cc: Gary R Hook <[email protected]>
> Signed-off-by: Ard Biesheuvel <[email protected]>

Acked-by: Gary R Hook <[email protected]>

> ---
> drivers/crypto/ccp/ccp-dev-v3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/ccp/ccp-dev-v3.c b/drivers/crypto/ccp/ccp-dev-v3.c
> index 0186b3df4c87..0d5576f6ad21 100644
> --- a/drivers/crypto/ccp/ccp-dev-v3.c
> +++ b/drivers/crypto/ccp/ccp-dev-v3.c
> @@ -586,6 +586,7 @@ const struct ccp_vdata ccpv3_platform = {
> .setup = NULL,
> .perform = &ccp3_actions,
> .offset = 0,
> + .rsamax = CCP_RSA_MAX_WIDTH,
> };
>
> const struct ccp_vdata ccpv3 = {

2019-12-11 09:39:35

by Herbert Xu

Subject: Re: [PATCH] crypto: ccp: set max RSA modulus size for v3 platform devices as well

On Wed, Nov 27, 2019 at 01:01:36PM +0100, Ard Biesheuvel wrote:
> AMD Seattle incorporates a non-PCI version of the v3 CCP crypto
> accelerator, and this version was left behind when the maximum
> RSA modulus size was parameterized in order to support v5 hardware
> which supports larger moduli than v3 hardware does. Due to this
> oversight, RSA acceleration no longer works at all on these systems.
>
> Fix this by setting the .rsamax property to the appropriate value
> for v3 platform hardware.
>
> Fixes: e28c190db66830c0 ("csrypto: ccp - Expand RSA support for a v5 ccp")
> Cc: Gary R Hook <[email protected]>
> Signed-off-by: Ard Biesheuvel <[email protected]>
> ---
> drivers/crypto/ccp/ccp-dev-v3.c | 1 +
> 1 file changed, 1 insertion(+)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt