2024-04-25 13:29:33

by Ritesh Harjani

Subject: [RFCv3 1/7] ext2: Remove comment related to journal handle

Signed-off-by: Ritesh Harjani (IBM) <[email protected]>
---
fs/ext2/inode.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
index f3d570a9302b..c4de3a94c4b2 100644
--- a/fs/ext2/inode.c
+++ b/fs/ext2/inode.c
@@ -615,8 +615,6 @@ static void ext2_splice_branch(struct inode *inode,
* allocations is needed - we simply release blocks and do not touch anything
* reachable from inode.
*
- * `handle' can be NULL if create == 0.
- *
* return > 0, # of blocks mapped or allocated.
* return = 0, if plain lookup failed.
* return < 0, error case.
--
2.44.0

2024-04-26 15:24:45

by Darrick J. Wong

Subject: Re: [RFCv3 1/7] ext2: Remove comment related to journal handle

On Thu, Apr 25, 2024 at 06:58:45PM +0530, Ritesh Harjani (IBM) wrote:
> Signed-off-by: Ritesh Harjani (IBM) <[email protected]>

What handle? ;)
Reviewed-by: Darrick J. Wong <[email protected]>

--D

> ---
> fs/ext2/inode.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index f3d570a9302b..c4de3a94c4b2 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
> @@ -615,8 +615,6 @@ static void ext2_splice_branch(struct inode *inode,
> * allocations is needed - we simply release blocks and do not touch anything
> * reachable from inode.
> *
> - * `handle' can be NULL if create == 0.
> - *
> * return > 0, # of blocks mapped or allocated.
> * return = 0, if plain lookup failed.
> * return < 0, error case.
> --
> 2.44.0
>
>