Turn on extents feature by default in ext4 filesystem. User could use
-o noextents to turn it off.
Signed-off-by: Mingming Cao <[email protected]>
Index: linux-2.6.22-rc4/fs/ext4/super.c
===================================================================
--- linux-2.6.22-rc4.orig/fs/ext4/super.c 2007-06-11 17:02:22.000000000 -0700
+++ linux-2.6.22-rc4/fs/ext4/super.c 2007-06-11 17:03:09.000000000 -0700
@@ -1546,6 +1546,12 @@
set_opt(sbi->s_mount_opt, RESERVATION);
+ /*
+ * turn on extents feature by default in ext4 filesystem
+ * User -o noextents to turn it off
+ */
+ set_opt (sbi->s_mount_opt, EXTENTS);
+
if (!parse_options ((char *) data, sb, &journal_inum, &journal_devnum,
NULL, 0))
goto failed_mount;
On Sun, 01 Jul 2007 03:36:01 -0400
Mingming Cao <[email protected]> wrote:
> Turn on extents feature by default in ext4 filesystem. User could use
> -o noextents to turn it off.
>
Oh, there you go.
>
> Index: linux-2.6.22-rc4/fs/ext4/super.c
> ===================================================================
> --- linux-2.6.22-rc4.orig/fs/ext4/super.c 2007-06-11 17:02:22.000000000 -0700
> +++ linux-2.6.22-rc4/fs/ext4/super.c 2007-06-11 17:03:09.000000000 -0700
> @@ -1546,6 +1546,12 @@
>
> set_opt(sbi->s_mount_opt, RESERVATION);
>
> + /*
> + * turn on extents feature by default in ext4 filesystem
> + * User -o noextents to turn it off
> + */
> + set_opt (sbi->s_mount_opt, EXTENTS);
> +
Broken coding style.
Please feed all the ext4 patches through scripts/checkpatch.pl (preferably
version 0.07 - see Andy's patch on lkml) and then consider addressing the
(quite large) number of mistakes which are detected.
On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote:
> On Sun, 01 Jul 2007 03:36:01 -0400
> Mingming Cao <[email protected]> wrote:
>
> > Turn on extents feature by default in ext4 filesystem. User could use
> > -o noextents to turn it off.
> >
>
> Oh, there you go.
>
> >
> > Index: linux-2.6.22-rc4/fs/ext4/super.c
> > ===================================================================
> > --- linux-2.6.22-rc4.orig/fs/ext4/super.c 2007-06-11 17:02:22.000000000 -0700
> > +++ linux-2.6.22-rc4/fs/ext4/super.c 2007-06-11 17:03:09.000000000 -0700
> > @@ -1546,6 +1546,12 @@
> >
> > set_opt(sbi->s_mount_opt, RESERVATION);
> >
> > + /*
> > + * turn on extents feature by default in ext4 filesystem
> > + * User -o noextents to turn it off
> > + */
> > + set_opt (sbi->s_mount_opt, EXTENTS);
> > +
>
> Broken coding style.
>
> Please feed all the ext4 patches through scripts/checkpatch.pl (preferably
> version 0.07 - see Andy's patch on lkml) and then consider addressing the
> (quite large) number of mistakes which are detected.
>
Sorry about this. I was using version 0.04. The latest one I can find
for now is 0.05(searching lkml), but it didn't catch this codling style
bug either. I appreciate if anyone can point me the version 0.07, thanks
Mingming
On Tue, Jul 10, 2007 at 05:35:13PM -0400, Mingming Cao wrote:
>
> Sorry about this. I was using version 0.04. The latest one I can find
> for now is 0.05(searching lkml), but it didn't catch this codling style
> bug either. I appreciate if anyone can point me the version 0.07, thanks
It's now in-tree in scripts/checkpatch.pl
(linus' tree is still at 0.06 though, I suspect Andrew has something
newer in -mm)
Dave
--
http://www.codemonkey.org.uk
On Tue, 2007-07-10 at 23:35 -0400, Dave Jones wrote:
> On Tue, Jul 10, 2007 at 05:35:13PM -0400, Mingming Cao wrote:
> >
> > Sorry about this. I was using version 0.04. The latest one I can find
> > for now is 0.05(searching lkml), but it didn't catch this codling style
> > bug either. I appreciate if anyone can point me the version 0.07, thanks
>
> It's now in-tree in scripts/checkpatch.pl
> (linus' tree is still at 0.06 though, I suspect Andrew has something
> newer in -mm)
>
Thanks, Andy has uploaded the 0.07 version at
http://www.shadowen.org/~apw/public/checkpatch/checkpatch.pl-0.07
Mingming