2008-06-11 06:01:29

by Shen Feng

Subject: [PATCH] ext4: return error when calling ext4_ext_split failed

ext4_ext_create_new_leaf must return error when its
calling to ext4_ext_split failed.

Signed-off-by: Shen Feng <[email protected]>
---
fs/ext4/extents.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index ff609df..177345d 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -981,6 +981,8 @@ repeat:
/* if we found index with free entry, then use that
* entry: create all needed subtree and add new leaf */
err = ext4_ext_split(handle, inode, path, newext, i);
+ if (err)
+ goto out;

/* refill path */
ext4_ext_drop_refs(path);
--
1.5.4.5

2008-06-11 11:39:45

by Aneesh Kumar K.V

Subject: Re: [PATCH] ext4: return error when calling ext4_ext_split failed

On Wed, Jun 11, 2008 at 01:58:02PM +0800, Shen Feng wrote:
>
> ext4_ext_create_new_leaf must return error when its
> calling to ext4_ext_split failed.
>
> Signed-off-by: Shen Feng <[email protected]>

Reviewed-by: Aneesh Kumar K.V <[email protected]>

> ---
> fs/ext4/extents.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index ff609df..177345d 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -981,6 +981,8 @@ repeat:
> /* if we found index with free entry, then use that
> * entry: create all needed subtree and add new leaf */
> err = ext4_ext_split(handle, inode, path, newext, i);
> + if (err)
> + goto out;
>
> /* refill path */
> ext4_ext_drop_refs(path);
> --
> 1.5.4.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2008-06-12 22:20:06

by Mingming Cao

Subject: Re: [PATCH] ext4: return error when calling ext4_ext_split failed

I have added to ext4 patch queue

Mingming
On Wed, 2008-06-11 at 13:58 +0800, Shen Feng wrote:
> ext4_ext_create_new_leaf must return error when its
> calling to ext4_ext_split failed.
>
> Signed-off-by: Shen Feng <[email protected]>
> ---
> fs/ext4/extents.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index ff609df..177345d 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -981,6 +981,8 @@ repeat:
> /* if we found index with free entry, then use that
> * entry: create all needed subtree and add new leaf */
> err = ext4_ext_split(handle, inode, path, newext, i);
> + if (err)
> + goto out;
>
> /* refill path */
> ext4_ext_drop_refs(path);