2022-09-17 00:43:40

by Li Zhong

Subject: [PATCH v2] fs/ext4/xattr: check the return value of ext4_xattr_inode_dec_ref()

Check the return value of ext4_xattr_inode_dec_ref(), which could return
error code and need to be warned.

Signed-off-by: Li Zhong <[email protected]>
---
fs/ext4/xattr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index 533216e80fa2..e6d62fd4ac31 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -1540,7 +1540,8 @@ static int ext4_xattr_inode_lookup_create(handle_t *handle, struct inode *inode,

err = ext4_xattr_inode_write(handle, ea_inode, value, value_len);
if (err) {
- ext4_xattr_inode_dec_ref(handle, ea_inode);
+ if (ext4_xattr_inode_dec_ref(handle, ea_inode))
+ ext4_warning_inode(ea_inode, "cleanup dec ref error %d", err);
iput(ea_inode);
return err;
}
--
2.25.1

2022-11-29 21:13:38

by Theodore Ts'o

Subject: Re: [PATCH v2] fs/ext4/xattr: check the return value of ext4_xattr_inode_dec_ref()

On Fri, 16 Sep 2022 17:28:16 -0700, Li Zhong wrote:
> Check the return value of ext4_xattr_inode_dec_ref(), which could return
> error code and need to be warned.
>
>

Applied, thanks!

[1/1] fs/ext4/xattr: check the return value of ext4_xattr_inode_dec_ref()
commit: 883a86e4276a9facf1a0fe6950e504f52b841853

Best regards,
--
Theodore Ts'o <[email protected]>