2024-04-17 13:01:26

by Pascal Hambourg

[permalink] [raw]
Subject: [PATCH] e2fsprogs: misc/mke2fs.8.in: Update default inode size description

Since a23b50cd ("mke2fs: warn about missing y2038 support when
formatting fresh ext4 fs"), the default inode size is 256 bytes
for all filesystems, including small and floppy, except for the
Hurd since it currently only supports 128-byte inodes.

Signed-off-by: Pascal Hambourg <[email protected]>
---
misc/mke2fs.8.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/misc/mke2fs.8.in b/misc/mke2fs.8.in
index 30f97bb5..8122e7f7 100644
--- a/misc/mke2fs.8.in
+++ b/misc/mke2fs.8.in
@@ -508,8 +508,8 @@ The default inode size is controlled by the
file. In the
.B mke2fs.conf
file shipped with e2fsprogs, the default inode size is 256 bytes for
-most file systems, except for small file systems where the inode size
-will be 128 bytes.
+all file systems, except for the GNU Hurd since it only supports
+128-byte inodes.
.TP
.B \-j
Create the file system with an ext3 journal. If the
--
2.39.2


2024-04-17 23:08:10

by Andreas Dilger

[permalink] [raw]
Subject: Re: [PATCH] e2fsprogs: misc/mke2fs.8.in: Update default inode size description

On Apr 17, 2024, at 5:48 AM, Pascal Hambourg <[email protected]> wrote:
>
> Since a23b50cd ("mke2fs: warn about missing y2038 support when
> formatting fresh ext4 fs"), the default inode size is 256 bytes
> for all filesystems, including small and floppy, except for the
> Hurd since it currently only supports 128-byte inodes.
>
> Signed-off-by: Pascal Hambourg <[email protected]>

Looks good.

Reviewed-by: Andreas Dilger <[email protected]>

> ---
> misc/mke2fs.8.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/misc/mke2fs.8.in b/misc/mke2fs.8.in
> index 30f97bb5..8122e7f7 100644
> --- a/misc/mke2fs.8.in
> +++ b/misc/mke2fs.8.in
> @@ -508,8 +508,8 @@ The default inode size is controlled by the
> file. In the
> .B mke2fs.conf
> file shipped with e2fsprogs, the default inode size is 256 bytes for
> -most file systems, except for small file systems where the inode size
> -will be 128 bytes.
> +all file systems, except for the GNU Hurd since it only supports
> +128-byte inodes.
> .TP
> .B \-j
> Create the file system with an ext3 journal. If the
> --
> 2.39.2


Cheers, Andreas






Attachments:
signature.asc (890.00 B)
Message signed with OpenPGP

2024-04-18 14:53:12

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH] e2fsprogs: misc/mke2fs.8.in: Update default inode size description


On Wed, 17 Apr 2024 13:48:22 +0200, Pascal Hambourg wrote:
> Since a23b50cd ("mke2fs: warn about missing y2038 support when
> formatting fresh ext4 fs"), the default inode size is 256 bytes
> for all filesystems, including small and floppy, except for the
> Hurd since it currently only supports 128-byte inodes.
>
>

Applied, thanks!

[1/1] e2fsprogs: misc/mke2fs.8.in: Update default inode size description
commit: 0d346c3a0851a52d332c6b4bb1ab021858ad3cc5

Best regards,
--
Theodore Ts'o <[email protected]>