This:
ftp://ftp.kernel.org/pub/linux/kernel/people/tytso/ext4-patches/2.6.20-ext4-1/broken-out/i_version_2_ext4_specific_code
has 100% broken whitespace: it uses spaces where there should be hard tabs.
Please let's not merge anything which does that.
On Thu, Feb 15, 2007 at 12:22:18AM -0800, Andrew Morton wrote:
>
> This:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/tytso/ext4-patches/2.6.20-ext4-1/broken-out/i_version_2_ext4_specific_code
>
> has 100% broken whitespace: it uses spaces where there should be hard tabs.
>
> Please let's not merge anything which does that.
Looking at this patch more closely, it looks like the whitespace was
damaged by a broken mailer. My apologies, I should have rejected the
patch.
Jean Noel, if you could resend the patch and make sure that your
mailer isn't screwing up whitespace? If necessary just attach it as a
text file instead of including it inline.
- Ted
Theodore Tso a ?crit :
> On Thu, Feb 15, 2007 at 12:22:18AM -0800, Andrew Morton wrote:
>> This:
>>
>> ftp://ftp.kernel.org/pub/linux/kernel/people/tytso/ext4-patches/2.6.20-ext4-1/broken-out/i_version_2_ext4_specific_code
>>
>> has 100% broken whitespace: it uses spaces where there should be hard tabs.
>>
>> Please let's not merge anything which does that.
>
> Looking at this patch more closely, it looks like the whitespace was
> damaged by a broken mailer. My apologies, I should have rejected the
> patch.
>
> Jean Noel, if you could resend the patch and make sure that your
> mailer isn't screwing up whitespace? If necessary just attach it as a
> text file instead of including it inline.
Sorry for that I will resend the patches in a proper form.