2011-09-23 22:07:22

by Hartley Sweeten

Subject: [PATCH] ext3/xattr_seciruty.c: local functions should be static

Quiets the sparse noise:

warning: symbol 'ext3_initxattrs' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Jan Kara <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Andreas Dilger <[email protected]>

---

diff --git a/fs/ext3/xattr_security.c b/fs/ext3/xattr_security.c
index 3c218b8..3f065f8 100644
--- a/fs/ext3/xattr_security.c
+++ b/fs/ext3/xattr_security.c
@@ -48,7 +48,7 @@ ext3_xattr_security_set(struct dentry *dentry, const char *name,
name, value, size, flags);
}

-int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
+static int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
void *fs_info)
{
const struct xattr *xattr;

2011-10-04 23:37:48

by Jan Kara

Subject: Re: [PATCH] ext3/xattr_seciruty.c: local functions should be static

On Fri 23-09-11 15:07:09, H Hartley Sweeten wrote:
> Quiets the sparse noise:
>
> warning: symbol 'ext3_initxattrs' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: Jan Kara <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Cc: Andreas Dilger <[email protected]>
Here applies the same comment as to the ext2 patch - not in current
Linus' kernel AFAICS.

Honza
>
> ---
>
> diff --git a/fs/ext3/xattr_security.c b/fs/ext3/xattr_security.c
> index 3c218b8..3f065f8 100644
> --- a/fs/ext3/xattr_security.c
> +++ b/fs/ext3/xattr_security.c
> @@ -48,7 +48,7 @@ ext3_xattr_security_set(struct dentry *dentry, const char *name,
> name, value, size, flags);
> }
>
> -int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> +static int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> void *fs_info)
> {
> const struct xattr *xattr;
--
Jan Kara <[email protected]>
SUSE Labs, CR

2011-10-05 17:27:18

by Hartley Sweeten

Subject: RE: [PATCH] ext3/xattr_seciruty.c: local functions should be static

On Tuesday, October 04, 2011 4:38 PM, Jan Kara wrote:
> On Fri 23-09-11 15:07:09, H Hartley Sweeten wrote:
>> Quiets the sparse noise:
>>
>> warning: symbol 'ext3_initxattrs' was not declared. Should it be static?
>>
>> Signed-off-by: H Hartley Sweeten <[email protected]>
>> Cc: Jan Kara <[email protected]>
>> Cc: Andrew Morton <[email protected]>
>> Cc: Andreas Dilger <[email protected]>
> Here applies the same comment as to the ext2 patch - not in current
> Linus' kernel AFAICS.

These are in linux-next due to:

commit 9d8f13ba3f4833219e50767b022b82cd0da930eb
Author: Mimi Zohar <[email protected]>
Date: Mon Jun 6 15:29:25 2011 -0400

security: new security_inode_init_security API adds function callback

I can repost these after this commit hits Linus' kernel if necessary.

Thanks,
Hartley

2011-10-05 20:18:17

by Jan Kara

Subject: Re: [PATCH] ext3/xattr_seciruty.c: local functions should be static

On Wed 05-10-11 12:27:06, H Hartley Sweeten wrote:
> On Tuesday, October 04, 2011 4:38 PM, Jan Kara wrote:
> > On Fri 23-09-11 15:07:09, H Hartley Sweeten wrote:
> >> Quiets the sparse noise:
> >>
> >> warning: symbol 'ext3_initxattrs' was not declared. Should it be static?
> >>
> >> Signed-off-by: H Hartley Sweeten <[email protected]>
> >> Cc: Jan Kara <[email protected]>
> >> Cc: Andrew Morton <[email protected]>
> >> Cc: Andreas Dilger <[email protected]>
> > Here applies the same comment as to the ext2 patch - not in current
> > Linus' kernel AFAICS.
>
> These are in linux-next due to:
>
> commit 9d8f13ba3f4833219e50767b022b82cd0da930eb
> Author: Mimi Zohar <[email protected]>
> Date: Mon Jun 6 15:29:25 2011 -0400
>
> security: new security_inode_init_security API adds function callback
>
> I can repost these after this commit hits Linus' kernel if necessary.
I see. OK, please repost when they hit Linus' kernel since I guess it's
not urgent to merge these.

Honza
--
Jan Kara <[email protected]>
SUSE Labs, CR