2015-02-04 11:17:57

by Xiaoguang Wang

Subject: [PATCH] ext4: fix comments in ext4_can_extents_be_merged()

Since commit 66369e0, we are allowed to merge unwritten extents,
so here these comments are wrong, remove it.

Signed-off-by: Xiaoguang Wang <[email protected]>
---
fs/ext4/extents.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index bed4308..2e6af88 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1717,12 +1717,6 @@ ext4_can_extents_be_merged(struct inode *inode, struct ext4_extent *ex1,
{
unsigned short ext1_ee_len, ext2_ee_len;

- /*
- * Make sure that both extents are initialized. We don't merge
- * unwritten extents so that we can be sure that end_io code has
- * the extent that was written properly split out and conversion to
- * initialized is trivial.
- */
if (ext4_ext_is_unwritten(ex1) != ext4_ext_is_unwritten(ex2))
return 0;

--
1.8.3.1

2015-04-02 20:55:48

by Theodore Ts'o

Subject: Re: [PATCH] ext4: fix comments in ext4_can_extents_be_merged()

On Wed, Feb 04, 2015 at 07:11:45PM +0800, Xiaoguang Wang wrote:
> Since commit 66369e0, we are allowed to merge unwritten extents,
> so here these comments are wrong, remove it.
>
> Signed-off-by: Xiaoguang Wang <[email protected]>

Thanks, applied.

BTW, the commit ID was wrong; I've corrected it to be a9b8241594add.

- Ted