2019-07-03 08:17:25

by shisiyuan

Subject: [PATCH] ext4: remove unnecessary error check

From: shisiyuan <[email protected]>

Remove unnecessary error check in ext4_file_write_iter(),
because this check will be done in upcoming later function --
ext4_write_checks() -> generic_write_checks()

Change-Id: I7b0ab27f693a50765c15b5eaa3f4e7c38f42e01e
Signed-off-by: shisiyuan <[email protected]>
---
fs/ext4/file.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index 5cb9aa3..9e4c39e 100644
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
@@ -224,8 +224,6 @@ ext4_file_write_iter(struct kiocb *iocb, struct iov_iter *from)
if (IS_DAX(inode))
return ext4_dax_write_iter(iocb, from);
#endif
- if (!o_direct && (iocb->ki_flags & IOCB_NOWAIT))
- return -EOPNOTSUPP;

if (!inode_trylock(inode)) {
if (iocb->ki_flags & IOCB_NOWAIT)
--
2.7.4

2019-07-18 15:18:21

by Theodore Ts'o

Subject: Re: [PATCH] ext4: remove unnecessary error check

On Wed, Jul 03, 2019 at 04:16:54PM +0800, Shi Siyuan wrote:
> From: shisiyuan <[email protected]>
>
> Remove unnecessary error check in ext4_file_write_iter(),
> because this check will be done in upcoming later function --
> ext4_write_checks() -> generic_write_checks()
>
> Change-Id: I7b0ab27f693a50765c15b5eaa3f4e7c38f42e01e
> Signed-off-by: shisiyuan <[email protected]>

Thanks, applied.

- Ted