2019-11-29 01:38:43

by Chengguang Xu

Subject: [Resend PATCH] ext2: set proper errno in error case of ext2_fill_super()

Set proper errno in the case of failure of
initializing percpu variables.

Signed-off-by: Chengguang Xu <[email protected]>
---
Forgot to cc ext4 maillist, so resend it.

fs/ext2/super.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 30c630d73f0f..74a9e3e71c13 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -1147,6 +1147,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
ext2_count_dirs(sb), GFP_KERNEL);
}
if (err) {
+ ret = err;
ext2_msg(sb, KERN_ERR, "error: insufficient memory");
goto failed_mount3;
}
--
2.20.1

2019-11-29 09:49:35

by Jan Kara

Subject: Re: [Resend PATCH] ext2: set proper errno in error case of ext2_fill_super()

On Fri 29-11-19 09:36:36, Chengguang Xu wrote:
> Set proper errno in the case of failure of
> initializing percpu variables.
>
> Signed-off-by: Chengguang Xu <[email protected]>

Thanks. I've added the patch to my tree.

Honza

> ---
> Forgot to cc ext4 maillist, so resend it.
>
> fs/ext2/super.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 30c630d73f0f..74a9e3e71c13 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -1147,6 +1147,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
> ext2_count_dirs(sb), GFP_KERNEL);
> }
> if (err) {
> + ret = err;
> ext2_msg(sb, KERN_ERR, "error: insufficient memory");
> goto failed_mount3;
> }
> --
> 2.20.1
>
>
>
--
Jan Kara <[email protected]>
SUSE Labs, CR