2020-04-20 04:05:13

by Jason Yan

Subject: [PATCH] ext4: remove unnecessary comparisons to bool

Fix the following coccicheck warning:

fs/ext4/extents_status.c:1057:5-28: WARNING: Comparison to bool
fs/ext4/inode.c:2314:18-24: WARNING: Comparison to bool

Signed-off-by: Jason Yan <[email protected]>
---
fs/ext4/extents_status.c | 2 +-
fs/ext4/inode.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c
index d996b44d2265..e75171535375 100644
--- a/fs/ext4/extents_status.c
+++ b/fs/ext4/extents_status.c
@@ -1054,7 +1054,7 @@ static void count_rsvd(struct inode *inode, ext4_lblk_t lblk, long len,
end = (end > ext4_es_end(es)) ? ext4_es_end(es) : end;

/* record the first block of the first delonly extent seen */
- if (rc->first_do_lblk_found == false) {
+ if (!rc->first_do_lblk_found) {
rc->first_do_lblk = i;
rc->first_do_lblk_found = true;
}
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 2a4aae6acdcb..acb8fedcba76 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2311,7 +2311,7 @@ static int mpage_map_and_submit_buffers(struct mpage_da_data *mpd)
* mapping, or maybe the page was submitted for IO.
* So we return to call further extent mapping.
*/
- if (err < 0 || map_bh == true)
+ if (err < 0 || map_bh)
goto out;
/* Page fully mapped - let IO run! */
err = mpage_submit_page(mpd, page);
--
2.21.1

2020-04-20 04:55:50

by Ritesh Harjani

Subject: Re: [PATCH] ext4: remove unnecessary comparisons to bool

On 4/20/20 9:59 AM, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> fs/ext4/extents_status.c:1057:5-28: WARNING: Comparison to bool
> fs/ext4/inode.c:2314:18-24: WARNING: Comparison to bool
>
> Signed-off-by: Jason Yan <[email protected]>

Thanks for the patch. Looks good to me.

Feel free to add:
Reviewed-by: Ritesh Harjani <[email protected]>

> ---
> fs/ext4/extents_status.c | 2 +-
> fs/ext4/inode.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c
> index d996b44d2265..e75171535375 100644
> --- a/fs/ext4/extents_status.c
> +++ b/fs/ext4/extents_status.c
> @@ -1054,7 +1054,7 @@ static void count_rsvd(struct inode *inode, ext4_lblk_t lblk, long len,
> end = (end > ext4_es_end(es)) ? ext4_es_end(es) : end;
>
> /* record the first block of the first delonly extent seen */
> - if (rc->first_do_lblk_found == false) {
> + if (!rc->first_do_lblk_found) {
> rc->first_do_lblk = i;
> rc->first_do_lblk_found = true;
> }
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 2a4aae6acdcb..acb8fedcba76 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -2311,7 +2311,7 @@ static int mpage_map_and_submit_buffers(struct mpage_da_data *mpd)
> * mapping, or maybe the page was submitted for IO.
> * So we return to call further extent mapping.
> */
> - if (err < 0 || map_bh == true)
> + if (err < 0 || map_bh)
> goto out;
> /* Page fully mapped - let IO run! */
> err = mpage_submit_page(mpd, page);
>

2020-05-14 14:48:32

by Theodore Ts'o

Subject: Re: [PATCH] ext4: remove unnecessary comparisons to bool

On Mon, Apr 20, 2020 at 12:29:18PM +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> fs/ext4/extents_status.c:1057:5-28: WARNING: Comparison to bool
> fs/ext4/inode.c:2314:18-24: WARNING: Comparison to bool
>
> Signed-off-by: Jason Yan <[email protected]>

Applied, thanks.

- Ted