2020-08-07 14:09:28

by brookxu.cn

Subject: [PATCH] ext4: delete invalid comments near ext4_mb_check_limits()

These comments do not seem to be related to ext4_mb_check_limits(),
it may be invalid.

Signed-off-by: Chunguang Xu <[email protected]>
---
fs/ext4/mballoc.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 577ce98..aaefeb4 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -1743,10 +1743,6 @@ static void ext4_mb_use_best_found(struct ext4_allocation_context *ac,

}

-/*
- * regular allocator, for general purposes allocation
- */
-
static void ext4_mb_check_limits(struct ext4_allocation_context *ac,
struct ext4_buddy *e4b,
int finish_group)
--
1.8.3.1

2020-08-13 15:35:59

by Ritesh Harjani

Subject: Re: [PATCH] ext4: delete invalid comments near ext4_mb_check_limits()

On 8/7/20 7:31 PM, brookxu wrote:
> These comments do not seem to be related to ext4_mb_check_limits(),
> it may be invalid.
>
> Signed-off-by: Chunguang Xu <[email protected]>

Either ways these comments are of no help and the
function has enough comments within.
So we should be good without it.

Reviewed-by: Ritesh Harjani <[email protected]>

> ---
> fs/ext4/mballoc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 577ce98..aaefeb4 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -1743,10 +1743,6 @@ static void ext4_mb_use_best_found(struct ext4_allocation_context *ac,
>
> }
>
> -/*
> - * regular allocator, for general purposes allocation
> - */
> -
> static void ext4_mb_check_limits(struct ext4_allocation_context *ac,
> struct ext4_buddy *e4b,
> int finish_group)
>

2020-08-18 18:16:39

by Theodore Ts'o

Subject: Re: [PATCH] ext4: delete invalid comments near ext4_mb_check_limits()

On Fri, Aug 07, 2020 at 10:01:33PM +0800, brookxu wrote:
> These comments do not seem to be related to ext4_mb_check_limits(),
> it may be invalid.
>
> Signed-off-by: Chunguang Xu <[email protected]>

Thanks, applied.

- Ted