LinuxLists.cc - [xfstests-bld PATCH] test-appliance: exclude generic/587 from the encrypt tests

2020-07-09 18:39:08

Subject: [xfstests-bld PATCH] test-appliance: exclude generic/587 from the encrypt tests

The encryption feature doesn't play well with quota, and generic/587
tests quota functionality.

Signed-off-by: Satya Tangirala <[email protected]>
---
.../test-appliance/files/root/fs/ext4/cfg/encrypt.exclude | 1 +
1 file changed, 1 insertion(+)

diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
index 47c26e7..07111c2 100644
--- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
+++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
@@ -24,6 +24,7 @@ generic/270
generic/381
generic/382
generic/566
+generic/587

# encryption doesn't play well with casefold (at least not yet)
generic/556
--
2.27.0.383.g050319c2ae-goog

2020-07-09 18:43:25

by Eric Biggers

[permalink] [raw]

Subject: Re: [xfstests-bld PATCH] test-appliance: exclude generic/587 from the encrypt tests

On Thu, Jul 09, 2020 at 06:37:01PM +0000, Satya Tangirala wrote:
> The encryption feature doesn't play well with quota, and generic/587
> tests quota functionality.
>
> Signed-off-by: Satya Tangirala <[email protected]>
> ---
> .../test-appliance/files/root/fs/ext4/cfg/encrypt.exclude | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
> index 47c26e7..07111c2 100644
> --- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
> +++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
> @@ -24,6 +24,7 @@ generic/270
> generic/381
> generic/382
> generic/566
> +generic/587
>
> # encryption doesn't play well with casefold (at least not yet)
> generic/556
> --

Can you update encrypt_1k.exclude as well?

- Eric

2020-07-09 18:59:36

by Satya Tangirala

[permalink] [raw]

Subject: [xfstests-bld PATCH v2] test-appliance: exclude generic/587 from the encrypt tests

The encryption feature doesn't play well with quota, and generic/587
tests quota functionality.

Signed-off-by: Satya Tangirala <[email protected]>
---
.../test-appliance/files/root/fs/ext4/cfg/encrypt.exclude | 1 +
.../test-appliance/files/root/fs/ext4/cfg/encrypt_1k.exclude | 1 +
2 files changed, 2 insertions(+)

diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
index 47c26e7..07111c2 100644
--- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
+++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
@@ -24,6 +24,7 @@ generic/270
generic/381
generic/382
generic/566
+generic/587

# encryption doesn't play well with casefold (at least not yet)
generic/556
diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt_1k.exclude b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt_1k.exclude
index cd60151..1f5a7e5 100644
--- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt_1k.exclude
+++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt_1k.exclude
@@ -20,6 +20,7 @@ generic/235
generic/270
generic/382
generic/204
+generic/587

# These tests are also excluded in 1k.exclude.
# See there for the reasons.
--
2.27.0.383.g050319c2ae-goog

2020-07-09 19:11:11

by Eric Biggers

[permalink] [raw]

Subject: Re: [xfstests-bld PATCH v2] test-appliance: exclude generic/587 from the encrypt tests

On Thu, Jul 09, 2020 at 06:58:32PM +0000, Satya Tangirala wrote:
> The encryption feature doesn't play well with quota, and generic/587
> tests quota functionality.
>
> Signed-off-by: Satya Tangirala <[email protected]>

Reviewed-by: Eric Biggers <[email protected]>

2020-09-01 16:18:33

by Eric Biggers

[permalink] [raw]

Subject: Re: [xfstests-bld PATCH v2] test-appliance: exclude generic/587 from the encrypt tests

On Thu, Jul 09, 2020 at 12:10:31PM -0700, Eric Biggers wrote:
> On Thu, Jul 09, 2020 at 06:58:32PM +0000, Satya Tangirala wrote:
> > The encryption feature doesn't play well with quota, and generic/587
> > tests quota functionality.
> >
> > Signed-off-by: Satya Tangirala <[email protected]>
>
> Reviewed-by: Eric Biggers <[email protected]>

Ted, are you planning to apply this?

2020-09-21 18:44:01

by Eric Biggers

[permalink] [raw]

Subject: Re: [xfstests-bld PATCH v2] test-appliance: exclude generic/587 from the encrypt tests

On Tue, Sep 01, 2020 at 09:17:26AM -0700, Eric Biggers wrote:
> On Thu, Jul 09, 2020 at 12:10:31PM -0700, Eric Biggers wrote:
> > On Thu, Jul 09, 2020 at 06:58:32PM +0000, Satya Tangirala wrote:
> > > The encryption feature doesn't play well with quota, and generic/587
> > > tests quota functionality.
> > >
> > > Signed-off-by: Satya Tangirala <[email protected]>
> >
> > Reviewed-by: Eric Biggers <[email protected]>
>
> Ted, are you planning to apply this?

Ping.

2020-09-24 17:28:11

by Theodore Ts'o

[permalink] [raw]

Subject: Re: [xfstests-bld PATCH v2] test-appliance: exclude generic/587 from the encrypt tests

2020-09-28 23:26:15

by Eric Biggers

[permalink] [raw]

Subject: Re: [xfstests-bld PATCH v2] test-appliance: exclude generic/587 from the encrypt tests

On Thu, Sep 24, 2020 at 01:27:29PM -0400, Theodore Y. Ts'o wrote:
> On Thu, Jul 09, 2020 at 12:10:31PM -0700, Eric Biggers wrote:
> > On Thu, Jul 09, 2020 at 06:58:32PM +0000, Satya Tangirala wrote:
> > > The encryption feature doesn't play well with quota, and generic/587
> > > tests quota functionality.
> > >
> > > Signed-off-by: Satya Tangirala <[email protected]>
> >
> > Reviewed-by: Eric Biggers <[email protected]>
>
> Applied, thanks
>

Thanks. Looks like you forgot to push? Also, the kernel.org and github
repositories for xfstests-bld aren't in sync.

- Eric