2021-05-26 06:07:22

by chenyichong

Subject: [PATCH] use local variables ei instead of invoking function EXT4_I

Signed-off-by: chenyichong <[email protected]>
---
fs/ext4/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index fe6045a46599..a5c4cd1c757b 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -374,7 +374,7 @@ void ext4_da_update_reserve_space(struct inode *inode,
ei->i_reserved_data_blocks -= used;
percpu_counter_sub(&sbi->s_dirtyclusters_counter, used);

- spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
+ spin_unlock(&ei->i_block_reservation_lock);

/* Update quota subsystem for data blocks */
if (quota_claim)
--
2.20.1

2021-05-27 03:42:23

by Ritesh Harjani

Subject: Re: [PATCH] use local variables ei instead of invoking function EXT4_I

On 21/05/26 01:29PM, chenyichong wrote:

Thanks for the patch. Looks good to me.
Feel free to add

Reviewed-by: Ritesh Harjani <[email protected]>


> Signed-off-by: chenyichong <[email protected]>
> ---
> fs/ext4/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index fe6045a46599..a5c4cd1c757b 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -374,7 +374,7 @@ void ext4_da_update_reserve_space(struct inode *inode,
> ei->i_reserved_data_blocks -= used;
> percpu_counter_sub(&sbi->s_dirtyclusters_counter, used);
>
> - spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
> + spin_unlock(&ei->i_block_reservation_lock);
>
> /* Update quota subsystem for data blocks */
> if (quota_claim)
> --
> 2.20.1
>
>
>

2021-06-17 21:31:30

by Theodore Ts'o

Subject: Re: [PATCH] use local variables ei instead of invoking function EXT4_I

On Wed, May 26, 2021 at 01:29:30PM +0800, chenyichong wrote:
> Signed-off-by: chenyichong <[email protected]>

Applied, thanks.

- Ted