2022-04-06 16:31:01

by wangjianjian (C)

Subject: [PATCH] ext4: Should ext4_bio_end_io be ext4_end_io_end ?

There is no ext4_bio_end_io, should it be ext4_end_io_end ?

Signed-off-by: Wang Jianjian <[email protected]>
---
fs/ext4/page-io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c
index 495ce59fb4ad..f9273acc4629 100644
--- a/fs/ext4/page-io.c
+++ b/fs/ext4/page-io.c
@@ -463,7 +463,7 @@ int ext4_bio_write_page(struct ext4_io_submit *io,
/*
* In the first loop we prepare and mark buffers to submit. We have to
* mark all buffers in the page before submitting so that
- * end_page_writeback() cannot be called from ext4_bio_end_io() when IO
+ * end_page_writeback() cannot be called from ext4_end_io_end() when IO
* on the first buffer finishes and we are still working on submitting
* the second buffer.
*/
--
2.32.0

2022-05-13 09:04:46

by Theodore Ts'o

Subject: Re: [PATCH] ext4: Should ext4_bio_end_io be ext4_end_io_end ?

On Wed, Apr 06, 2022 at 08:52:51PM +0800, Wang Jianjian wrote:
> There is no ext4_bio_end_io, should it be ext4_end_io_end ?

I believe the correction in the comment should be "cannot be called
from ext4_end_bio()".

- Ted