2022-09-08 09:22:28

by Ritesh Harjani

[permalink] [raw]
Subject: Re: [PATCH v2 13/13] ext4: factor out ext4_journal_data_mode_check()

On 22/09/03 11:01AM, Jason Yan wrote:
> Factor out ext4_journal_data_mode_check(). No functional change.
>
> Signed-off-by: Jason Yan <[email protected]>
> Reviewed-by: Jan Kara<[email protected]>
> ---
> fs/ext4/super.c | 60 ++++++++++++++++++++++++++++---------------------
> 1 file changed, 35 insertions(+), 25 deletions(-)

Looks good to me. Thanks overall for the nice refactoring.
Function __ext4_fill_super() indeed looks a lot better now :)

Reviewed-by: Ritesh Harjani (IBM) <[email protected]>