2023-01-04 09:07:31

by Eric Biggers

Subject: [e2fsprogs PATCH] libext2fs: remove unused variable in ext2fs_xattrs_read_inode()

From: Eric Biggers <[email protected]>

Address the following compiler warning with gcc -Wall:

ext_attr.c: In function ‘ext2fs_xattrs_read_inode’:
ext_attr.c:1000:16: warning: unused variable ‘i’ [-Wunused-variable]
1000 | size_t i;
| ^

Cc: Andreas Dilger <[email protected]>
Signed-off-by: Eric Biggers <[email protected]>
---
lib/ext2fs/ext_attr.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/lib/ext2fs/ext_attr.c b/lib/ext2fs/ext_attr.c
index d36fe68d..6fc4214c 100644
--- a/lib/ext2fs/ext_attr.c
+++ b/lib/ext2fs/ext_attr.c
@@ -997,7 +997,6 @@ errcode_t ext2fs_xattrs_read_inode(struct ext2_xattr_handle *handle,
unsigned int storage_size;
char *start, *block_buf = NULL;
blk64_t blk;
- size_t i;
errcode_t err = 0;

EXT2_CHECK_MAGIC(handle, EXT2_ET_MAGIC_EA_HANDLE);
--
2.39.0

2023-01-04 10:25:38

by Lukas Czerner

Subject: Re: [e2fsprogs PATCH] libext2fs: remove unused variable in ext2fs_xattrs_read_inode()

On Wed, Jan 04, 2023 at 01:03:14AM -0800, Eric Biggers wrote:
> From: Eric Biggers <[email protected]>
>
> Address the following compiler warning with gcc -Wall:
>
> ext_attr.c: In function ‘ext2fs_xattrs_read_inode’:
> ext_attr.c:1000:16: warning: unused variable ‘i’ [-Wunused-variable]
> 1000 | size_t i;
> | ^

You might as well remove the unnecessary newline at the top of the
function.

But regardless, you can add.

Reviewed-by: Lukas Czerner <[email protected]>

Thanks!
-Lukas

>
> Cc: Andreas Dilger <[email protected]>
> Signed-off-by: Eric Biggers <[email protected]>
> ---
> lib/ext2fs/ext_attr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/ext2fs/ext_attr.c b/lib/ext2fs/ext_attr.c
> index d36fe68d..6fc4214c 100644
> --- a/lib/ext2fs/ext_attr.c
> +++ b/lib/ext2fs/ext_attr.c
> @@ -997,7 +997,6 @@ errcode_t ext2fs_xattrs_read_inode(struct ext2_xattr_handle *handle,
> unsigned int storage_size;
> char *start, *block_buf = NULL;
> blk64_t blk;
> - size_t i;
> errcode_t err = 0;
>
> EXT2_CHECK_MAGIC(handle, EXT2_ET_MAGIC_EA_HANDLE);
> --
> 2.39.0
>