2023-03-17 09:10:12

by Zhang Yi

Subject: [PATCH v4 2/2] ext4: add journal cycled recording support

From: Zhang Yi <[email protected]>

Always enable 'JBD2_CYCLE_RECORD' journal option on ext4, letting the
jbd2 continue to record new journal transactions from the recovered
journal head or the checkpointed transactions in the previous mount.

Signed-off-by: Zhang Yi <[email protected]>
---
fs/ext4/super.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 88f7b8a88c76..9b46adae241b 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -5691,6 +5691,11 @@ static void ext4_init_journal_params(struct super_block *sb, journal_t *journal)
journal->j_flags |= JBD2_ABORT_ON_SYNCDATA_ERR;
else
journal->j_flags &= ~JBD2_ABORT_ON_SYNCDATA_ERR;
+ /*
+ * Always enable journal cycle record option, letting the journal
+ * records log transactions continuously between each mount.
+ */
+ journal->j_flags |= JBD2_CYCLE_RECORD;
write_unlock(&journal->j_state_lock);
}

--
2.31.1

2023-03-17 13:01:38

by Jan Kara

Subject: Re: [PATCH v4 2/2] ext4: add journal cycled recording support

On Fri 17-03-23 17:09:26, Zhang Yi wrote:
> From: Zhang Yi <[email protected]>
>
> Always enable 'JBD2_CYCLE_RECORD' journal option on ext4, letting the
> jbd2 continue to record new journal transactions from the recovered
> journal head or the checkpointed transactions in the previous mount.
>
> Signed-off-by: Zhang Yi <[email protected]>

Looks good to me. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> fs/ext4/super.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 88f7b8a88c76..9b46adae241b 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -5691,6 +5691,11 @@ static void ext4_init_journal_params(struct super_block *sb, journal_t *journal)
> journal->j_flags |= JBD2_ABORT_ON_SYNCDATA_ERR;
> else
> journal->j_flags &= ~JBD2_ABORT_ON_SYNCDATA_ERR;
> + /*
> + * Always enable journal cycle record option, letting the journal
> + * records log transactions continuously between each mount.
> + */
> + journal->j_flags |= JBD2_CYCLE_RECORD;
> write_unlock(&journal->j_state_lock);
> }
>
> --
> 2.31.1
>
--
Jan Kara <[email protected]>
SUSE Labs, CR