2023-08-08 20:34:36

by Christoph Hellwig

Subject: [PATCH 12/13] ntfs3: don't call sync_blockdev in ntfs_put_super

kill_block_super will call sync_blockdev just a tad later already.

Signed-off-by: Christoph Hellwig <[email protected]>
---
fs/ntfs3/super.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index bb985d3756d949..727138933a9324 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -629,8 +629,6 @@ static void ntfs_put_super(struct super_block *sb)
put_mount_options(sbi->options);
ntfs3_free_sbi(sbi);
sb->s_fs_info = NULL;
-
- sync_blockdev(sb->s_bdev);
}

static int ntfs_statfs(struct dentry *dentry, struct kstatfs *buf)
--
2.39.2

2023-08-09 08:23:34

by Christian Brauner

Subject: Re: [PATCH 12/13] ntfs3: don't call sync_blockdev in ntfs_put_super

On Tue, Aug 08, 2023 at 09:15:59AM -0700, Christoph Hellwig wrote:
> kill_block_super will call sync_blockdev just a tad later already.
>
> Signed-off-by: Christoph Hellwig <[email protected]>
> ---

Looks good to me,
Reviewed-by: Christian Brauner <[email protected]>