2023-07-24 15:22:15

by Wang Jianjian

Subject: [PATCH] jbd2: Remove unused t_handle_lock

Since commit 4f98186848('jbd2: refactor wait logic for transaction
updates into a common function'), this lock has been no use.
---
include/linux/jbd2.h | 5 -----
1 file changed, 5 deletions(-)

diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
index d860499e15e4..8199235dbaf3 100644
--- a/include/linux/jbd2.h
+++ b/include/linux/jbd2.h
@@ -636,11 +636,6 @@ struct transaction_s
*/
struct list_head t_inode_list;

- /*
- * Protects info related to handles
- */
- spinlock_t t_handle_lock;
-
/*
* Longest time some handle had to wait for running transaction
*/
--
2.34.3

2023-07-26 11:32:14

by Zhang Yi

Subject: Re: [PATCH] jbd2: Remove unused t_handle_lock

On 2023/7/24 22:58, Wang Jianjian wrote:
> Since commit 4f98186848('jbd2: refactor wait logic for transaction
> updates into a common function'), this lock has been no use.

Hi, I don't think the commit is correct, it should be
f7f497cb7024 ("jbd2: kill t_handle_lock transaction spinlock").

Thanks,
Yi.

> ---
> include/linux/jbd2.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index d860499e15e4..8199235dbaf3 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -636,11 +636,6 @@ struct transaction_s
> */
> struct list_head t_inode_list;
>
> - /*
> - * Protects info related to handles
> - */
> - spinlock_t t_handle_lock;
> -
> /*
> * Longest time some handle had to wait for running transaction
> */
>