2011-08-30 09:53:59

by Li Haifeng

Subject: [PATCH] fix the outdated comment in ext2_nfs_get_inode()

The function iget referred by the comment is replaced by ext2_iget .
And the ext2_read_inode() is not exist, the ext2_iget is "neater". So
the comment is fixed here.

Signed-off-by: Li Haifeng <[email protected]>
---
fs/ext2/super.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 1dd62ed..994ced3 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -327,10 +327,8 @@ static struct inode *ext2_nfs_get_inode(struct
super_block *sb,
if (ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count))
return ERR_PTR(-ESTALE);

- /* iget isn't really right if the inode is currently unallocated!!
- * ext2_read_inode currently does appropriate checks, but
- * it might be "neater" to call ext2_get_inode first and check
- * if the inode is valid.....
+ /*
+ * ext2_iget isn't really right if the inode is currently unallocated!!
*/
inode = ext2_iget(sb, ino);
if (IS_ERR(inode))
--
1.7.4.1

2011-08-30 10:35:47

by Jan Kara

Subject: Re: [PATCH] fix the outdated comment in ext2_nfs_get_inode()

On Tue 30-08-11 17:53:58, Li Haifeng wrote:
> The function iget referred by the comment is replaced by ext2_iget .
> And the ext2_read_inode() is not exist, the ext2_iget is "neater". So
> the comment is fixed here.
>
> Signed-off-by: Li Haifeng <[email protected]>
> ---
> fs/ext2/super.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 1dd62ed..994ced3 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -327,10 +327,8 @@ static struct inode *ext2_nfs_get_inode(struct
> super_block *sb,
> if (ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count))
> return ERR_PTR(-ESTALE);
>
> - /* iget isn't really right if the inode is currently unallocated!!
> - * ext2_read_inode currently does appropriate checks, but
> - * it might be "neater" to call ext2_get_inode first and check
> - * if the inode is valid.....
> + /*
> + * ext2_iget isn't really right if the inode is currently unallocated!!
OK, but we should keep there a note that ext2_iget() does appropriate
checks to handle stale inodes.

Honza
> */
> inode = ext2_iget(sb, ino);
> if (IS_ERR(inode))
> --
> 1.7.4.1
--
Jan Kara <[email protected]>
SUSE Labs, CR

2011-08-30 11:29:30

by Li Haifeng

Subject: Re: [PATCH] fix the outdated comment in ext2_nfs_get_inode()

Thanks for your point. I will remake this patch.

2011/8/30 Jan Kara <[email protected]>
>
> On Tue 30-08-11 17:53:58, Li Haifeng wrote:
> > The function iget ?referred by the comment is replaced by ext2_iget .
> > And the ext2_read_inode() is not exist, the ext2_iget is "neater". So
> > the comment is fixed here.
> >
> > Signed-off-by: Li Haifeng <[email protected]>
> > ---
> > ?fs/ext2/super.c | ? ?6 ++----
> > ?1 files changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> > index 1dd62ed..994ced3 100644
> > --- a/fs/ext2/super.c
> > +++ b/fs/ext2/super.c
> > @@ -327,10 +327,8 @@ static struct inode *ext2_nfs_get_inode(struct
> > super_block *sb,
> > ? ? if (ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count))
> > ? ? ? ? return ERR_PTR(-ESTALE);
> >
> > - ? /* iget isn't really right if the inode is currently unallocated!!
> > - ? ?* ext2_read_inode currently does appropriate checks, but
> > - ? ?* it might be "neater" to call ext2_get_inode first and check
> > - ? ?* if the inode is valid.....
> > + ? /*
> > + ? ?* ext2_iget isn't really right if the inode is currently unallocated!!
> ?OK, but we should keep there a note that ext2_iget() does appropriate
> checks to handle stale inodes.
>
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?Honza
> > ? ? ?*/
> > ? ? inode = ext2_iget(sb, ino);
> > ? ? if (IS_ERR(inode))
> > --
> > 1.7.4.1
> --
> Jan Kara <[email protected]>
> SUSE Labs, CR