by Aditya Kali

[permalink] [raw]

Subject: Re: [PATCH 8/9] tests: add basic e2fsck regression test for fixing the quota inode

On Sat, May 10, 2014 at 9:32 PM, Theodore Ts'o <[email protected]> wrote:
> Signed-off-by: "Theodore Ts'o" <[email protected]>
> Cc: [email protected]

Reviewed-by: Aditya Kali <[email protected]>

Thanks!

> ---
> tests/f_quota/debugfs-cmds | 7 +++++++
> tests/f_quota/expect.0 | 21 +++++++++++++++++++++
> tests/f_quota/expect.1 | 13 +++++++++++++
> tests/f_quota/expect.2 | 7 +++++++
> tests/f_quota/image.gz | Bin 0 -> 1046 bytes
> tests/f_quota/name | 1 +
> tests/f_quota/script | 4 ++++
> 7 files changed, 53 insertions(+)
> create mode 100644 tests/f_quota/debugfs-cmds
> create mode 100644 tests/f_quota/expect.0
> create mode 100644 tests/f_quota/expect.1
> create mode 100644 tests/f_quota/expect.2
> create mode 100644 tests/f_quota/image.gz
> create mode 100644 tests/f_quota/name
> create mode 100644 tests/f_quota/script
>
> diff --git a/tests/f_quota/debugfs-cmds b/tests/f_quota/debugfs-cmds
> new file mode 100644
> index 0000000..112a3ff
> --- /dev/null
> +++ b/tests/f_quota/debugfs-cmds
> @@ -0,0 +1,7 @@
> +list_quota user
> +list_quota group
> +get_quota user 0
> +get_quota user 100
> +get_quota user 34
> +get_quota group 0
> +
> diff --git a/tests/f_quota/expect.0 b/tests/f_quota/expect.0
> new file mode 100644
> index 0000000..c0ad63d
> --- /dev/null
> +++ b/tests/f_quota/expect.0
> @@ -0,0 +1,21 @@
> +debugfs: list_quota user
> + user id blocks quota limit inodes quota limit
> + 0 13312 0 0 2 0 0
> + 34 1024 0 0 1 0 0
> + 100 2048 32 50 2 20 30
> +debugfs: list_quota group
> +group id blocks quota limit inodes quota limit
> + 0 16384 0 0 5 0 0
> +debugfs: get_quota user 0
> + user id blocks quota limit inodes quota limit
> + 0 13312 0 0 2 0 0
> +debugfs: get_quota user 100
> + user id blocks quota limit inodes quota limit
> + 100 2048 32 50 2 20 30
> +debugfs: get_quota user 34
> + user id blocks quota limit inodes quota limit
> + 34 1024 0 0 1 0 0
> +debugfs: get_quota group 0
> +group id blocks quota limit inodes quota limit
> + 0 16384 0 0 5 0 0
> +debugfs:
> diff --git a/tests/f_quota/expect.1 b/tests/f_quota/expect.1
> new file mode 100644
> index 0000000..0b3b4cf
> --- /dev/null
> +++ b/tests/f_quota/expect.1
> @@ -0,0 +1,13 @@
> +Pass 1: Checking inodes, blocks, and sizes
> +Pass 2: Checking directory structure
> +Pass 3: Checking directory connectivity
> +Pass 4: Checking reference counts
> +Pass 5: Checking group summary information
> +[QUOTA WARNING] Usage inconsistent for ID 0:actual (13312, 2) != expected (14336, 3)
> +[QUOTA WARNING] Usage inconsistent for ID 100:actual (2048, 2) != expected (1024, 1)
> +Update quota info for quota type 0? yes
> +
> +
> +test_filesys: ***** FILE SYSTEM WAS MODIFIED *****
> +test_filesys: 14/16 files (14.3% non-contiguous), 36/100 blocks
> +Exit status is 1
> diff --git a/tests/f_quota/expect.2 b/tests/f_quota/expect.2
> new file mode 100644
> index 0000000..bfc558d
> --- /dev/null
> +++ b/tests/f_quota/expect.2
> @@ -0,0 +1,7 @@
> +Pass 1: Checking inodes, blocks, and sizes
> +Pass 2: Checking directory structure
> +Pass 3: Checking directory connectivity
> +Pass 4: Checking reference counts
> +Pass 5: Checking group summary information
> +test_filesys: 14/16 files (14.3% non-contiguous), 36/100 blocks
> +Exit status is 0
> diff --git a/tests/f_quota/image.gz b/tests/f_quota/image.gz
> new file mode 100644
> index 0000000000000000000000000000000000000000..9cea6556e941fb0e3fb2bf09a29895ca246cad50
> GIT binary patch
> literal 1046
> zc-o!F{WF^f0KoBdZspF1-D*lrSk+5+=nz^>MD?0oJL0vO3C%`l6v@;wr3l-3tD%~?
> zzGRWMMx?1^&PXhr%sb7Cmj-$B49Sp)h}T6l&vyG0_PzW3@`csfKw9?*32#~HRWX@3
> zk}G7(Gj~kbmczDY#KKO6Eue#tb%hIIj*ow|o40q~c;Lm+%?A5U)Z)IZ(z}mu`9vY_
> z%(UEzKYq`?uX<Tj`=`q8T`0!k(sBS<D~Bu2Qq!};>D&73?b1R3|1Veohm+-H_0EfE
> zk4X=7q^nJ%ZDXq3U5n<c)?m_!hDdc_$DEod!|)5(SZ^n)e>mZCb-u@b<@u8#JO^xX
> zaTWlG==RYiCMkYIf+uTgPMPB#vD(0c{1WpN)zA;BhBeR`nlTiAv!UC}@8l8=nskyC
> z!sLE0k%#opz6m;OkuW#qJn_?NJ?&6Z!O?Lt{CAG#(Kd5zEUO#LF|49+0{010eR)@}
> zaj_E|jq(o-Uqn{IMC$ye<kKp6LN@l5DqU0ecxfZW&kv<6G@N@7?NXQFT3YHk-1>~9
> zQb-<swsh&&rOLyBkk=jLFCxyDTWMjjVA-MdYt&QAu{~%zIpWQK3nD1V-Jv`r=aA7O
> zy(Li6^W0RTs(Ps$-q8&J5kpU10^j~Vfh-U>PeVD@Rz#V(jGNqnW8-fTLB4|S`?IaW
> zS*LQ-`#GVY2eQS$-$mu)J=9%qUD@%?B(Z})An%kKKtUerTxMTt<sX`pu%x1Jq++$$
> z9KBj&HEQpcC<d({5Qsp|HD4p${&@4NMZ9+)t=3_*l!+m%Unvm98kFioG5ned=z7Jz
> zKAy2D?zUYOR}mZb?pkDG@FH+x`|B`M6;@6DjVt^vbb6i07p);D2S`^foo7ri?nRJm
> z1cDGs;*nuj`FF<9U4XA_ChzaE22vPpLEs#)ZDOQS3s&ScP|3rf^k-!Om3=@JkCz7G
> z0H&dI2S{KEjT2mh<r~(KVrY9%s#T}G3;}0Z!U5feBmh8wJs8V=AIy&m66xfzvpa^P
> zjX}o#u4Ox+D=!$&p}lZgb%~4jyZ%JObERQsWIlGR8`TU-8oX$I+&H-OiyZMD{C$@!
> zgp;E#FF2uLr9F;%HKqzD(I`YKK_l@lO%!x;OdB;To`udzf#RB((iUFQlT@Kp7IA^_
> zQzZX>0JEn{L%DUK@U(AeZBwQfb69VGr6Qx{My9ZGzv6aB;=<=X(!ZRv6HM8+2s(bc
> zKR(wV@pAS}%@34MpfGxoajRx+e0oh<lRoBEA4OaEptZYQAq{4?nM_mtp3#?KZBEaZ
> zkBZOuIx;@WOZ07alPFM03harg?7Wu7;R<woJqFuCY3lnBvIm9y{{-%b)+I!f5pw?+
> F<R3nT9HRgL
>
> literal 0
> Hc-jL100001
>
> diff --git a/tests/f_quota/name b/tests/f_quota/name
> new file mode 100644
> index 0000000..27ea8ba
> --- /dev/null
> +++ b/tests/f_quota/name
> @@ -0,0 +1 @@
> +fix incorrect usage stats in quota
> diff --git a/tests/f_quota/script b/tests/f_quota/script
> new file mode 100644
> index 0000000..bf25e07
> --- /dev/null
> +++ b/tests/f_quota/script
> @@ -0,0 +1,4 @@
> +AFTER_CMD='$DEBUGFS -f $test_dir/debugfs-cmds $TMPFILE 2>&1 | sed -f $cmd_dir/filter.sed > $test_name.0.log'
> +PASS_ZERO=true
> +
> +. $cmd_dir/run_e2fsck
> --
> 1.9.0
>

--
Aditya

2014-05-13 07:32:52

by Aditya Kali

[permalink] [raw]

Subject: Re: [PATCH 9/9] quota: remove warning message that we have fixed the nasty quota bugs

On Sat, May 10, 2014 at 9:32 PM, Theodore Ts'o <[email protected]> wrote:
> We no longer need to reference https://ext4.wiki.kernel.org/index.php/Quota
> since we've fixed the nasty bugs associated with e2fsck and the quota
> feature. The wiki page will be updated once we've done a release that
> includes these fixes indicated the verison which these problems have
> been fixed.
>
> Signed-off-by: "Theodore Ts'o" <[email protected]>
> Cc: [email protected]

Reviewed-by: Aditya Kali <[email protected]>

Thanks!

> ---
> misc/ext4.5.in | 7 -------
> misc/mke2fs.c | 7 -------
> misc/tune2fs.c | 4 ----
> tests/m_quota/expect.1 | 4 ----
> 4 files changed, 22 deletions(-)
>
> diff --git a/misc/ext4.5.in b/misc/ext4.5.in
> index 5ec39f5..134c19f 100644
> --- a/misc/ext4.5.in
> +++ b/misc/ext4.5.in
> @@ -210,13 +210,6 @@ shared storage environments.
> @QUOTA_MAN_COMMENT@Causes the quota files (i.e., user.quota and
> @[email protected] which existed
> @QUOTA_MAN_COMMENT@in the older quota design) to be hidden inodes.
> -@[email protected]
> -@[email protected] Warning:
> -@QUOTA_MAN_COMMENT@The quota feature is still under development,
> -@QUOTA_MAN_COMMENT@and may not be fully supported with your kernel
> -@QUOTA_MAN_COMMENT@or may have various bugs. Please
> -@QUOTA_MAN_COMMENT@see https://ext4.wiki.kernel.org/index.php/Quota
> -@QUOTA_MAN_COMMENT@for more details.
> .TP
> .B resize_inode
> .br
> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
> index e1fd40e..9c4b0b2 100644
> --- a/misc/mke2fs.c
> +++ b/misc/mke2fs.c
> @@ -2162,13 +2162,6 @@ profile_error:
> "See https://ext4.wiki.kernel.org/"
> "index.php/Bigalloc for more information\n\n"));
>
> - if (!quiet &&
> - (fs_param.s_feature_ro_compat & EXT4_FEATURE_RO_COMPAT_QUOTA))
> - fprintf(stderr, "%s", _("\nWarning: the quota feature is "
> - "still under development\n"
> - "See https://ext4.wiki.kernel.org/"
> - "index.php/Quota for more information\n\n"));
> -
> /* Since sparse_super is the default, we would only have a problem
> * here if it was explicitly disabled.
> */
> diff --git a/misc/tune2fs.c b/misc/tune2fs.c
> index 37f0b56..9ba32a1 100644
> --- a/misc/tune2fs.c
> +++ b/misc/tune2fs.c
> @@ -776,10 +776,6 @@ static void handle_quota_options(ext2_filsys fs)
> quota_release_context(&qctx);
>
> if ((usrquota == QOPT_ENABLE) || (grpquota == QOPT_ENABLE)) {
> - fprintf(stderr, "%s", _("\nWarning: the quota feature is still "
> - "under development\n"
> - "See https://ext4.wiki.kernel.org/"
> - "index.php/Quota for more information\n\n"));
> fs->super->s_feature_ro_compat |= EXT4_FEATURE_RO_COMPAT_QUOTA;
> ext2fs_mark_super_dirty(fs);
> } else if (!fs->super->s_usr_quota_inum &&
> diff --git a/tests/m_quota/expect.1 b/tests/m_quota/expect.1
> index a0f6501..787871c 100644
> --- a/tests/m_quota/expect.1
> +++ b/tests/m_quota/expect.1
> @@ -1,7 +1,3 @@
> -
> -Warning: the quota feature is still under development
> -See https://ext4.wiki.kernel.org/index.php/Quota for more information
> -
> Creating filesystem with 131072 1k blocks and 32768 inodes
> Superblock backups stored on blocks:
> 8193, 24577, 40961, 57345, 73729
> --
> 1.9.0
>

--
Aditya