2021-05-20 06:56:56

by Tian Tao

Subject: [PATCH v2] ext4: remove set but rewrite variables

In the ext4_dx_add_entry function, the at variable is assigned but will
reset just after “again:” label. So delete the unnecessary assignment.
this will not chang the logic.

Signed-off-by: Tian Tao <[email protected]>
Reviewed-by: Artem Blagodarenko <[email protected]>
---

v2: update the commit message.
---
fs/ext4/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index afb9d05..18bbf15 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2497,7 +2497,7 @@ static int ext4_dx_add_entry(handle_t *handle, struct ext4_filename *fname,

/* Which index block gets the new entry? */
if (at - entries >= icount1) {
- frame->at = at = at - entries - icount1 + entries2;
+ frame->at = at - entries - icount1 + entries2;
frame->entries = entries = entries2;
swap(frame->bh, bh2);
}
--
2.7.4

2021-06-17 15:02:11

by Theodore Ts'o

Subject: Re: [PATCH v2] ext4: remove set but rewrite variables

On Thu, May 20, 2021 at 02:55:52PM +0800, Tian Tao wrote:
> In the ext4_dx_add_entry function, the at variable is assigned but will
> reset just after “again:” label. So delete the unnecessary assignment.
> this will not chang the logic.
>
> Signed-off-by: Tian Tao <[email protected]>
> Reviewed-by: Artem Blagodarenko <[email protected]>

Applied, thanks.

- Ted