2010-03-17 10:12:15

by Steven Liu

[permalink] [raw]
Subject: [PATCH] ext4: Fix coding style in fs/ext4/move_extent.c

fix a code style in fs/ext4/move_extent.c

Signed-off-by: LiuQi <[email protected]>
---
fs/ext4/move_extent.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
index aa5fe28..b399358 100644
--- a/fs/ext4/move_extent.c
+++ b/fs/ext4/move_extent.c
@@ -481,6 +481,7 @@ mext_leaf_block(handle_t *handle, struct inode *orig_inode,
int depth = ext_depth(orig_inode);
int ret;

+ start_ext.ee_block = end_ext.ee_block = 0;
o_start = o_end = oext = orig_path[depth].p_ext;
oext_alen = ext4_ext_get_actual_len(oext);
start_ext.ee_len = end_ext.ee_len = 0;
--
1.6.0.3


2010-03-22 00:20:50

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH] ext4: Fix coding style in fs/ext4/move_extent.c

On Wed, Mar 17, 2010 at 06:12:14PM +0800, Steven Liu wrote:
> fix a code style in fs/ext4/move_extent.c
>
> Signed-off-by: LiuQi <[email protected]>

I've added this to the ext4 patch queue with the following changelog
description:

ext4: Fix coding style in fs/ext4/move_extent.c

From: Steven Liu <[email protected]>

Making sure ee_block is initialized to zero to prevent gcc from
kvetching. It's harmless (although it's not obvious that it's
harmless) from code inspection:

fs/ext4/move_extent.c:478: warning: 'start_ext.ee_block' may be used
uninitialized in this function

Thanks to Stefan Richter for first bringing this to the attention of
[email protected].

Signed-off-by: LiuQi <[email protected]>
Signed-off-by: "Theodore Ts'o" <[email protected]>
Cc: Stefan Richter <[email protected]>

- Ted