2023-04-17 03:05:25

by Kemeng Shi

Subject: [PATCH v3 11/19] ext4: fix wrong unit use in ext4_mb_new_blocks

Function ext4_mb_new_blocks_simple needs count in cluster. Function
ext4_mb_new_blocks accepts count in block. Convert count to cluster
to fix the mismatch.

Signed-off-by: Kemeng Shi <[email protected]>
---
fs/ext4/mballoc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 4a345e3c1c78..6d4471fd3049 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -6315,7 +6315,7 @@ void ext4_free_blocks(handle_t *handle, struct inode *inode,
}

if (sbi->s_mount_state & EXT4_FC_REPLAY) {
- ext4_free_blocks_simple(inode, block, count);
+ ext4_free_blocks_simple(inode, block, EXT4_NUM_B2C(sbi, count));
return;
}

--
2.30.0

2023-05-12 06:40:36

by Ojaswin Mujoo

Subject: Re: [PATCH v3 11/19] ext4: fix wrong unit use in ext4_mb_new_blocks

On Mon, Apr 17, 2023 at 07:06:09PM +0800, Kemeng Shi wrote:
> Function ext4_mb_new_blocks_simple needs count in cluster. Function

So there seems to be a typo in the commit header and commit message. I believe
you mean ext4_mb_free_blocks() and ext4_mb_free_blocks_simple() ?

If that is the case, once corrected feel free to add:

Reviewed-by: Ojaswin Mujoo <[email protected]>

> ext4_mb_new_blocks accepts count in block. Convert count to cluster
> to fix the mismatch.
>
> Signed-off-by: Kemeng Shi <[email protected]>
> ---
> fs/ext4/mballoc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 4a345e3c1c78..6d4471fd3049 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -6315,7 +6315,7 @@ void ext4_free_blocks(handle_t *handle, struct inode *inode,
> }
>
> if (sbi->s_mount_state & EXT4_FC_REPLAY) {
> - ext4_free_blocks_simple(inode, block, count);
> + ext4_free_blocks_simple(inode, block, EXT4_NUM_B2C(sbi, count));
> return;
> }
>
> --
> 2.30.0
>

2023-05-12 08:29:31

by Kemeng Shi

Subject: Re: [PATCH v3 11/19] ext4: fix wrong unit use in ext4_mb_new_blocks

on 5/12/2023 2:39 PM, Ojaswin Mujoo wrote:
> On Mon, Apr 17, 2023 at 07:06:09PM +0800, Kemeng Shi wrote:
>> Function ext4_mb_new_blocks_simple needs count in cluster. Function
>
> So there seems to be a typo in the commit header and commit message. I believe
> you mean ext4_mb_free_blocks() and ext4_mb_free_blocks_simple() ?
> Hi Ojaswin, thanks for review. Yes, it's a typo, I mean ext4_free_blocks and
ext4_mb_free_blocks_simple. I will fix the commit in next version.
> If that is the case, once corrected feel free to add:
>
> Reviewed-by: Ojaswin Mujoo <[email protected]>


--
Best wishes
Kemeng Shi