2019-12-25 02:40:00

by Zheng Bin

Subject: [PATCH] ext4: use true,false for bool variable

Fixes coccicheck warning:

fs/ext4/extents.c:5271:6-12: WARNING: Assignment of 0/1 to bool variable
fs/ext4/extents.c:5287:4-10: WARNING: Assignment of 0/1 to bool variable

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: zhengbin <[email protected]>
---
fs/ext4/extents.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 0e8708b..d8611be 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -5268,7 +5268,7 @@ ext4_ext_shift_path_extents(struct ext4_ext_path *path, ext4_lblk_t shift,
{
int depth, err = 0;
struct ext4_extent *ex_start, *ex_last;
- bool update = 0;
+ bool update = false;
depth = path->p_depth;

while (depth >= 0) {
@@ -5284,7 +5284,7 @@ ext4_ext_shift_path_extents(struct ext4_ext_path *path, ext4_lblk_t shift,
goto out;

if (ex_start == EXT_FIRST_EXTENT(path[depth].p_hdr))
- update = 1;
+ update = true;

while (ex_start <= ex_last) {
if (SHIFT == SHIFT_LEFT) {
--
2.7.4

2020-01-09 11:28:12

by Jan Kara

Subject: Re: [PATCH] ext4: use true,false for bool variable

On Wed 25-12-19 10:45:59, zhengbin wrote:
> Fixes coccicheck warning:
>
> fs/ext4/extents.c:5271:6-12: WARNING: Assignment of 0/1 to bool variable
> fs/ext4/extents.c:5287:4-10: WARNING: Assignment of 0/1 to bool variable
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: zhengbin <[email protected]>

Looks good to me. You can add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> fs/ext4/extents.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 0e8708b..d8611be 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -5268,7 +5268,7 @@ ext4_ext_shift_path_extents(struct ext4_ext_path *path, ext4_lblk_t shift,
> {
> int depth, err = 0;
> struct ext4_extent *ex_start, *ex_last;
> - bool update = 0;
> + bool update = false;
> depth = path->p_depth;
>
> while (depth >= 0) {
> @@ -5284,7 +5284,7 @@ ext4_ext_shift_path_extents(struct ext4_ext_path *path, ext4_lblk_t shift,
> goto out;
>
> if (ex_start == EXT_FIRST_EXTENT(path[depth].p_hdr))
> - update = 1;
> + update = true;
>
> while (ex_start <= ex_last) {
> if (SHIFT == SHIFT_LEFT) {
> --
> 2.7.4
>
--
Jan Kara <[email protected]>
SUSE Labs, CR

2020-01-13 19:05:54

by Theodore Ts'o

Subject: Re: [PATCH] ext4: use true,false for bool variable

On Thu, Jan 09, 2020 at 11:22:54AM +0100, Jan Kara wrote:
> On Wed 25-12-19 10:45:59, zhengbin wrote:
> > Fixes coccicheck warning:
> >
> > fs/ext4/extents.c:5271:6-12: WARNING: Assignment of 0/1 to bool variable
> > fs/ext4/extents.c:5287:4-10: WARNING: Assignment of 0/1 to bool variable
> >
> > Reported-by: Hulk Robot <[email protected]>
> > Signed-off-by: zhengbin <[email protected]>
>
> Looks good to me. You can add:
>
> Reviewed-by: Jan Kara <[email protected]>

Applied, thanks.

- Ted