2006-06-12 23:03:33

by Amit Gud

[permalink] [raw]

Subject: [PATCH 1 / 1] Move NFS mount code from util-linux to nfs-utils - take2

---

_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

---

Attachments:

nfsmount-migration-to-nfsutils-v4.patch (90.33 kB)
(No filename) (0.00 B)
(No filename) (140.00 B)
Download all attachments

2006-06-13 02:25:19

by Ian Kent

[permalink] [raw]

Subject: Re: [PATCH 1 / 1] Move NFS mount code from util-linux to nfs-utils - take2

---

On Mon, 2006-06-12 at 19:06 -0400, Amit Gud wrote:
> Neil,
>
> It avoids code duplication (of parsing the options and error checking)
> if we don't branch two different binaries for the NFSv4 and older versions.
>

> +
> + if(!nomtab)
> + add_mtab(spec, mount_point, nfs_mount_vers == 4 ? "nfs4" : "nfs",
> + flags, extra_opts, 0, 0);

If mtab~ is busy won't this cause mtab to get out of sync?

Ian



_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

2006-06-13 03:12:10

by Amit Gud

[permalink] [raw]

Subject: Re: [PATCH 1 / 1] Move NFS mount code from util-linux to nfs-utils - take2

---

Ian Kent wrote:
> On Mon, 2006-06-12 at 19:06 -0400, Amit Gud wrote:
>> Neil,
>>
>> It avoids code duplication (of parsing the options and error checking)
>> if we don't branch two different binaries for the NFSv4 and older versions.
>>
>
>> +
>> + if(!nomtab)
>> + add_mtab(spec, mount_point, nfs_mount_vers == 4 ? "nfs4" : "nfs",
>> + flags, extra_opts, 0, 0);
>
> If mtab~ is busy won't this cause mtab to get out of sync?
>

Cannot really spin over until the file lock is achieved, it may
potentially never be.


AG
--
May the source be with you.
http://www.cis.ksu.edu/~gud



_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs