Hi all,
After merging the wireless-drivers-next tree, today's linux-next build
(x86_64 allmodconfig) produced these warnings:
drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function 'iwl_parse_tlv_firmware':
drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1098:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (iwlwifi_mod_params.enable_ini)
^
drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1100:3: note: here
default:
^~~~~~~
drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: In function 'iwl_parse_fw_dbg_tlv':
drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:203:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
iwl_fw_dbg_copy_tlv(trans, tlv, true);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:204:3: note: here
default:
^~~~~~~
Introduced by commit
f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs")
These are noted because I use -Wimplict-fallthrough
The warnings can be suppressed by adding a comment like
/* fall through */
at the appropriate place to indicate that the fallthough is intended.
--
Cheers,
Stephen Rothwell
Stephen Rothwell <[email protected]> writes:
> Hi all,
>
> After merging the wireless-drivers-next tree, today's linux-next build
> (x86_64 allmodconfig) produced these warnings:
>
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function 'iwl_parse_tlv_firmware':
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1098:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (iwlwifi_mod_params.enable_ini)
> ^
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1100:3: note: here
> default:
> ^~~~~~~
> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: In function 'iwl_parse_fw_dbg_tlv':
> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:203:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
> iwl_fw_dbg_copy_tlv(trans, tlv, true);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:204:3: note: here
> default:
> ^~~~~~~
>
> Introduced by commit
>
> f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs")
>
> These are noted because I use -Wimplict-fallthrough
>
> The warnings can be suppressed by adding a comment like
> /* fall through */
> at the appropriate place to indicate that the fallthough is intended.
I take it that -Wimplict-fallthrough is not enabled by default yet? So
Dave and Linus won't see these warnings?
What I'm planning is to send a pull request to Dave today and fix these
warnings in the next pull request. Does that sound good?
--
Kalle Valo
Hi Kalle,
On Fri, 30 Nov 2018 06:33:47 +0200 Kalle Valo <[email protected]> wrote:
>
> I take it that -Wimplict-fallthrough is not enabled by default yet? So
> Dave and Linus won't see these warnings?
Correct.
> What I'm planning is to send a pull request to Dave today and fix these
> warnings in the next pull request. Does that sound good?
That sounds fine.
--
Cheers,
Stephen Rothwell
Stephen Rothwell <[email protected]> writes:
> Hi Kalle,
>
> On Fri, 30 Nov 2018 06:33:47 +0200 Kalle Valo <[email protected]> wrote:
>>
>> I take it that -Wimplict-fallthrough is not enabled by default yet? So
>> Dave and Linus won't see these warnings?
>
> Correct.
>
>> What I'm planning is to send a pull request to Dave today and fix these
>> warnings in the next pull request. Does that sound good?
>
> That sounds fine.
Great, thanks for the confirmation. I'll then send the pull request
today.
--
Kalle Valo
On Fri, 2018-11-30 at 09:43 +0200, Kalle Valo wrote:
> Stephen Rothwell <[email protected]> writes:
>
> > Hi Kalle,
> >
> > On Fri, 30 Nov 2018 06:33:47 +0200 Kalle Valo <[email protected]
> > > wrote:
> > > I take it that -Wimplict-fallthrough is not enabled by default
> > > yet? So
> > > Dave and Linus won't see these warnings?
> >
> > Correct.
> >
> > > What I'm planning is to send a pull request to Dave today and fix
> > > these
> > > warnings in the next pull request. Does that sound good?
> >
> > That sounds fine.
>
> Great, thanks for the confirmation. I'll then send the pull request
> today.
Just FYI, I enabled this by default in our internal tree so we will
notice when it happens before sending the patch upstream.
--
Cheers,
Luca.
On 12/3/18 6:38 AM, Luciano Coelho wrote:
> On Fri, 2018-11-30 at 09:43 +0200, Kalle Valo wrote:
>> Stephen Rothwell <[email protected]> writes:
>>
>>> Hi Kalle,
>>>
>>> On Fri, 30 Nov 2018 06:33:47 +0200 Kalle Valo <[email protected]
>>>> wrote:
>>>> I take it that -Wimplict-fallthrough is not enabled by default
>>>> yet? So
>>>> Dave and Linus won't see these warnings?
>>>
>>> Correct.
>>>
>>>> What I'm planning is to send a pull request to Dave today and fix
>>>> these
>>>> warnings in the next pull request. Does that sound good?
>>>
>>> That sounds fine.
>>
>> Great, thanks for the confirmation. I'll then send the pull request
>> today.
>
> Just FYI, I enabled this by default in our internal tree so we will
> notice when it happens before sending the patch upstream.
>
That's really great.
Thanks, Luca
--
Gustavo
Hi all,
On Fri, 30 Nov 2018 12:05:55 +1100 Stephen Rothwell <[email protected]> wrote:
>
> After merging the wireless-drivers-next tree, today's linux-next build
> (x86_64 allmodconfig) produced these warnings:
>
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function 'iwl_parse_tlv_firmware':
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1098:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (iwlwifi_mod_params.enable_ini)
> ^
> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1100:3: note: here
> default:
> ^~~~~~~
> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: In function 'iwl_parse_fw_dbg_tlv':
> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:203:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
> iwl_fw_dbg_copy_tlv(trans, tlv, true);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:204:3: note: here
> default:
> ^~~~~~~
>
> Introduced by commit
>
> f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs")
>
> These are noted because I use -Wimplict-fallthrough
>
> The warnings can be suppressed by adding a comment like
> /* fall through */
> at the appropriate place to indicate that the fallthough is intended.
I am still seeing these warnings (but in the net-next tree now) and I
do not see a fix patch in the wireless-drivers-next tree.
--
Cheers,
Stephen Rothwell
Stephen Rothwell <[email protected]> writes:
> On Fri, 30 Nov 2018 12:05:55 +1100 Stephen Rothwell <[email protected]> wrote:
>>
>> After merging the wireless-drivers-next tree, today's linux-next build
>> (x86_64 allmodconfig) produced these warnings:
>>
>> drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function 'iwl_parse_tlv_firmware':
>> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1098:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (iwlwifi_mod_params.enable_ini)
>> ^
>> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1100:3: note: here
>> default:
>> ^~~~~~~
>> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: In function 'iwl_parse_fw_dbg_tlv':
>> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:203:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> iwl_fw_dbg_copy_tlv(trans, tlv, true);
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:204:3: note: here
>> default:
>> ^~~~~~~
>>
>> Introduced by commit
>>
>> f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs")
>>
>> These are noted because I use -Wimplict-fallthrough
>>
>> The warnings can be suppressed by adding a comment like
>> /* fall through */
>> at the appropriate place to indicate that the fallthough is intended.
>
> I am still seeing these warnings (but in the net-next tree now) and I
> do not see a fix patch in the wireless-drivers-next tree.
Luca did submit a patch[1] for cfg80211 to fix those but I don't see any
patches for iwlwifi (even in the one pending pull request he sent), not
sure what happened. I know that Luca is already on holidays but adding
Emmanuel, maybe he can help here?
[1] https://patchwork.kernel.org/patch/10732065/
--
Kalle Valo
>
> Stephen Rothwell <[email protected]> writes:
>
> > On Fri, 30 Nov 2018 12:05:55 +1100 Stephen Rothwell
> <[email protected]> wrote:
> >>
> >> After merging the wireless-drivers-next tree, today's linux-next
> >> build
> >> (x86_64 allmodconfig) produced these warnings:
> >>
> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function
> 'iwl_parse_tlv_firmware':
> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1098:7: warning: this
> statement may fall through [-Wimplicit-fallthrough=]
> >> if (iwlwifi_mod_params.enable_ini)
> >> ^
> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1100:3: note: here
> >> default:
> >> ^~~~~~~
> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: In function
> 'iwl_parse_fw_dbg_tlv':
> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:203:4: warning: this
> statement may fall through [-Wimplicit-fallthrough=]
> >> iwl_fw_dbg_copy_tlv(trans, tlv, true);
> >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:204:3: note: here
> >> default:
> >> ^~~~~~~
> >>
> >> Introduced by commit
> >>
> >> f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs")
> >>
> >> These are noted because I use -Wimplict-fallthrough
> >>
> >> The warnings can be suppressed by adding a comment like
> >> /* fall through */
> >> at the appropriate place to indicate that the fallthough is intended.
> >
> > I am still seeing these warnings (but in the net-next tree now) and I
> > do not see a fix patch in the wireless-drivers-next tree.
>
> Luca did submit a patch[1] for cfg80211 to fix those but I don't see any
> patches for iwlwifi (even in the one pending pull request he sent), not sure
> what happened. I know that Luca is already on holidays but adding
> Emmanuel, maybe he can help here?
>
Just sent a patch.
On Wed, 2018-12-19 at 08:31 +0000, Grumbach, Emmanuel wrote:
> > Stephen Rothwell <[email protected]> writes:
> >
> > > On Fri, 30 Nov 2018 12:05:55 +1100 Stephen Rothwell
> > <[email protected]> wrote:
> > > > After merging the wireless-drivers-next tree, today's linux-next
> > > > build
> > > > (x86_64 allmodconfig) produced these warnings:
> > > >
> > > > drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function
> > 'iwl_parse_tlv_firmware':
> > > > drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1098:7: warning: this
> > statement may fall through [-Wimplicit-fallthrough=]
> > > > if (iwlwifi_mod_params.enable_ini)
> > > > ^
> > > > drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1100:3: note: here
> > > > default:
> > > > ^~~~~~~
> > > > drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: In function
> > 'iwl_parse_fw_dbg_tlv':
> > > > drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:203:4: warning: this
> > statement may fall through [-Wimplicit-fallthrough=]
> > > > iwl_fw_dbg_copy_tlv(trans, tlv, true);
> > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > > drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:204:3: note: here
> > > > default:
> > > > ^~~~~~~
> > > >
> > > > Introduced by commit
> > > >
> > > > f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs")
> > > >
> > > > These are noted because I use -Wimplict-fallthrough
> > > >
> > > > The warnings can be suppressed by adding a comment like
> > > > /* fall through */
> > > > at the appropriate place to indicate that the fallthough is intended.
> > >
> > > I am still seeing these warnings (but in the net-next tree now) and I
> > > do not see a fix patch in the wireless-drivers-next tree.
> >
> > Luca did submit a patch[1] for cfg80211 to fix those but I don't see any
> > patches for iwlwifi (even in the one pending pull request he sent), not sure
> > what happened. I know that Luca is already on holidays but adding
> > Emmanuel, maybe he can help here?
> >
>
> Just sent a patch.
Those patches were still queued for upstreaming and I didn't think they
were that urgent, so I didn't pick them.
--
Luca.
"Grumbach, Emmanuel" <[email protected]> writes:
>>
>> Stephen Rothwell <[email protected]> writes:
>>
>> > On Fri, 30 Nov 2018 12:05:55 +1100 Stephen Rothwell
>> <[email protected]> wrote:
>> >>
>> >> After merging the wireless-drivers-next tree, today's linux-next
>> >> build
>> >> (x86_64 allmodconfig) produced these warnings:
>> >>
>> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function
>> 'iwl_parse_tlv_firmware':
>> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1098:7: warning: this
>> statement may fall through [-Wimplicit-fallthrough=]
>> >> if (iwlwifi_mod_params.enable_ini)
>> >> ^
>> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1100:3: note: here
>> >> default:
>> >> ^~~~~~~
>> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: In function
>> 'iwl_parse_fw_dbg_tlv':
>> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:203:4: warning: this
>> statement may fall through [-Wimplicit-fallthrough=]
>> >> iwl_fw_dbg_copy_tlv(trans, tlv, true);
>> >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> >> drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:204:3: note: here
>> >> default:
>> >> ^~~~~~~
>> >>
>> >> Introduced by commit
>> >>
>> >> f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs")
>> >>
>> >> These are noted because I use -Wimplict-fallthrough
>> >>
>> >> The warnings can be suppressed by adding a comment like
>> >> /* fall through */
>> >> at the appropriate place to indicate that the fallthough is intended.
>> >
>> > I am still seeing these warnings (but in the net-next tree now) and I
>> > do not see a fix patch in the wireless-drivers-next tree.
>>
>> Luca did submit a patch[1] for cfg80211 to fix those but I don't see any
>> patches for iwlwifi (even in the one pending pull request he sent), not sure
>> what happened. I know that Luca is already on holidays but adding
>> Emmanuel, maybe he can help here?
>>
>
> Just sent a patch.
I see it thanks:
https://patchwork.kernel.org/patch/10736967/
I'll try to get it to tomorrow's linux-next build.
--
Kalle Valo