2010-10-25 07:16:11

by Mohammed Shafi Shajakhan

Subject: [PATCH] ath9k: Properly assign boolean types Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>

From: Mohammed Shafi Shajakhan <[email protected]>

---
drivers/net/wireless/ath/ath9k/rc.c | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net/wireless/ath/ath9k/rc.c
index 0cee90c..0c70839 100644
--- a/drivers/net/wireless/ath/ath9k/rc.c
+++ b/drivers/net/wireless/ath/ath9k/rc.c
@@ -1444,12 +1444,15 @@ static void ath_rate_init(void *priv, struct ieee80211_supported_band *sband,
ath_rc_priv->neg_ht_rates.rs_nrates = j;
}

- is_cw40 = sta->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40;
+ is_cw40 = (sta->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40) ?
+ true : false;

if (is_cw40)
- is_sgi = sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_40;
+ is_sgi = (sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_40) ?
+ true : false;
else if (sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_SGI_20)
- is_sgi = sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_20;
+ is_sgi = (sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_20) ?
+ true : false

/* Choose rate table first */

--
1.7.0.4

2010-10-25 16:28:56

by Luis R. Rodriguez

Subject: Re: [PATCH] ath9k: Properly assign boolean types Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>

On Mon, Oct 25, 2010 at 12:16:01AM -0700, Mohammed Shajakhan wrote:
> From: Mohammed Shafi Shajakhan <[email protected]>

Your SOB is missing, and you put it on the subject

Luis

>
> ---
> drivers/net/wireless/ath/ath9k/rc.c | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net/wireless/ath/ath9k/rc.c
> index 0cee90c..0c70839 100644
> --- a/drivers/net/wireless/ath/ath9k/rc.c
> +++ b/drivers/net/wireless/ath/ath9k/rc.c
> @@ -1444,12 +1444,15 @@ static void ath_rate_init(void *priv, struct ieee80211_supported_band *sband,
> ath_rc_priv->neg_ht_rates.rs_nrates = j;
> }
>
> - is_cw40 = sta->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40;
> + is_cw40 = (sta->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40) ?
> + true : false;
>
> if (is_cw40)
> - is_sgi = sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_40;
> + is_sgi = (sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_40) ?
> + true : false;
> else if (sc->sc_ah->caps.hw_caps & ATH9K_HW_CAP_SGI_20)
> - is_sgi = sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_20;
> + is_sgi = (sta->ht_cap.cap & IEEE80211_HT_CAP_SGI_20) ?
> + true : false
>
> /* Choose rate table first */
>
> --
> 1.7.0.4
>

2010-10-26 04:28:11

by Mohammed Shafi Shajakhan

Subject: Re: [PATCH] ath9k: Properly assign boolean types Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>

I will make the change send a new patch.Thanks Luis.
regards,
shafi

On Monday 25 October 2010 09:58 PM, Luis Rodriguez wrote:
> On Mon, Oct 25, 2010 at 12:16:01AM -0700, Mohammed Shajakhan wrote:
>
>> From: Mohammed Shafi Shajakhan<[email protected]>
>>
> Your SOB is missing, and you put it on the subject
>
> Luis
>
>
>> ---
>> drivers/net/wireless/ath/ath9k/rc.c | 9 ++++++---
>> 1 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net/wireless/ath/ath9k/rc.c
>> index 0cee90c..0c70839 100644
>> --- a/drivers/net/wireless/ath/ath9k/rc.c
>> +++ b/drivers/net/wireless/ath/ath9k/rc.c
>> @@ -1444,12 +1444,15 @@ static void ath_rate_init(void *priv, struct ieee80211_supported_band *sband,
>> ath_rc_priv->neg_ht_rates.rs_nrates = j;
>> }
>>
>> - is_cw40 = sta->ht_cap.cap& IEEE80211_HT_CAP_SUP_WIDTH_20_40;
>> + is_cw40 = (sta->ht_cap.cap& IEEE80211_HT_CAP_SUP_WIDTH_20_40) ?
>> + true : false;
>>
>> if (is_cw40)
>> - is_sgi = sta->ht_cap.cap& IEEE80211_HT_CAP_SGI_40;
>> + is_sgi = (sta->ht_cap.cap& IEEE80211_HT_CAP_SGI_40) ?
>> + true : false;
>> else if (sc->sc_ah->caps.hw_caps& ATH9K_HW_CAP_SGI_20)
>> - is_sgi = sta->ht_cap.cap& IEEE80211_HT_CAP_SGI_20;
>> + is_sgi = (sta->ht_cap.cap& IEEE80211_HT_CAP_SGI_20) ?
>> + true : false
>>
>> /* Choose rate table first */
>>
>> --
>> 1.7.0.4
>>
>>
> .
>
>

2010-10-26 02:42:39

by Bob Copeland

Subject: Re: [PATCH] ath9k: Properly assign boolean types Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>

On Mon, Oct 25, 2010 at 11:58 AM, Ben Greear <[email protected]> wrote:
> On 10/25/2010 12:16 AM, Mohammed Shafi Shajakhan wrote:
>> - ? ? ? is_cw40 = sta->ht_cap.cap& ?IEEE80211_HT_CAP_SUP_WIDTH_20_40;
>> + ? ? ? is_cw40 = (sta->ht_cap.cap& ?IEEE80211_HT_CAP_SUP_WIDTH_20_40) ?
>> + ? ? ? ? ? ? ? true : false;
>
> Maybe use:
> is_cw40 = !!(sta->ht_cap.cap& ?IEEE80211_HT_CAP_SUP_WIDTH_20_40);
>
> Seems a bit simpler to me...

Agreed, !! is idiomatic.

--
Bob Copeland %% http://www.bobcopeland.com

2010-10-26 04:36:40

by Mohammed Shafi Shajakhan

Subject: Re: [PATCH] ath9k: Properly assign boolean types Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>

Thanks , thought of that, but the code seems to use true/false approach,
will send a new patch with this simple fix.
thanks,
shafi

On Monday 25 October 2010 09:28 PM, Ben Greear wrote:
> On 10/25/2010 12:16 AM, Mohammed Shafi Shajakhan wrote:
>
>> From: Mohammed Shafi Shajakhan<[email protected]>
>>
>> ---
>> drivers/net/wireless/ath/ath9k/rc.c | 9 ++++++---
>> 1 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net/wireless/ath/ath9k/rc.c
>> index 0cee90c..0c70839 100644
>> --- a/drivers/net/wireless/ath/ath9k/rc.c
>> +++ b/drivers/net/wireless/ath/ath9k/rc.c
>> @@ -1444,12 +1444,15 @@ static void ath_rate_init(void *priv, struct ieee80211_supported_band *sband,
>> ath_rc_priv->neg_ht_rates.rs_nrates = j;
>> }
>>
>> - is_cw40 = sta->ht_cap.cap& IEEE80211_HT_CAP_SUP_WIDTH_20_40;
>> + is_cw40 = (sta->ht_cap.cap& IEEE80211_HT_CAP_SUP_WIDTH_20_40) ?
>> + true : false;
>>
> Maybe use:
> is_cw40 = !!(sta->ht_cap.cap& IEEE80211_HT_CAP_SUP_WIDTH_20_40);
>
> Seems a bit simpler to me...
>
> Ben
>
>
>
>> if (is_cw40)
>> - is_sgi = sta->ht_cap.cap& IEEE80211_HT_CAP_SGI_40;
>> + is_sgi = (sta->ht_cap.cap& IEEE80211_HT_CAP_SGI_40) ?
>> + true : false;
>> else if (sc->sc_ah->caps.hw_caps& ATH9K_HW_CAP_SGI_20)
>> - is_sgi = sta->ht_cap.cap& IEEE80211_HT_CAP_SGI_20;
>> + is_sgi = (sta->ht_cap.cap& IEEE80211_HT_CAP_SGI_20) ?
>> + true : false
>>
>> /* Choose rate table first */
>>
>>
>
>

2010-10-25 15:59:05

by Ben Greear

Subject: Re: [PATCH] ath9k: Properly assign boolean types Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>

On 10/25/2010 12:16 AM, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan<[email protected]>
>
> ---
> drivers/net/wireless/ath/ath9k/rc.c | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net/wireless/ath/ath9k/rc.c
> index 0cee90c..0c70839 100644
> --- a/drivers/net/wireless/ath/ath9k/rc.c
> +++ b/drivers/net/wireless/ath/ath9k/rc.c
> @@ -1444,12 +1444,15 @@ static void ath_rate_init(void *priv, struct ieee80211_supported_band *sband,
> ath_rc_priv->neg_ht_rates.rs_nrates = j;
> }
>
> - is_cw40 = sta->ht_cap.cap& IEEE80211_HT_CAP_SUP_WIDTH_20_40;
> + is_cw40 = (sta->ht_cap.cap& IEEE80211_HT_CAP_SUP_WIDTH_20_40) ?
> + true : false;

Maybe use:
is_cw40 = !!(sta->ht_cap.cap& IEEE80211_HT_CAP_SUP_WIDTH_20_40);

Seems a bit simpler to me...

Ben


>
> if (is_cw40)
> - is_sgi = sta->ht_cap.cap& IEEE80211_HT_CAP_SGI_40;
> + is_sgi = (sta->ht_cap.cap& IEEE80211_HT_CAP_SGI_40) ?
> + true : false;
> else if (sc->sc_ah->caps.hw_caps& ATH9K_HW_CAP_SGI_20)
> - is_sgi = sta->ht_cap.cap& IEEE80211_HT_CAP_SGI_20;
> + is_sgi = (sta->ht_cap.cap& IEEE80211_HT_CAP_SGI_20) ?
> + true : false
>
> /* Choose rate table first */
>


--
Ben Greear <[email protected]>
Candela Technologies Inc http://www.candelatech.com