Because of not clearing Bit 14 of AR_WA, the ASPM L1 is not
enabled when entering into sleep mode. AR9462 does not need
bit 14 to be set.
Cc: [email protected]
Signed-off-by: Rajkumar Manoharan <[email protected]>
---
drivers/net/wireless/ath/ath9k/hw.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index c4ae0d1..255a538 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -542,6 +542,9 @@ static int __ath9k_hw_init(struct ath_hw *ah)
return -EIO;
}
+ if (AR_SREV_9462(ah))
+ ah->WARegVal &= ~AR_WA_D3_L1_DISABLE;
+
ath9k_hw_init_defaults(ah);
ath9k_hw_init_config(ah);
@@ -1830,8 +1833,7 @@ static void ath9k_set_power_sleep(struct ath_hw *ah, int setChip)
}
/* Clear Bit 14 of AR_WA after putting chip into Full Sleep mode. */
- if (!AR_SREV_9480(ah))
- REG_WRITE(ah, AR_WA, ah->WARegVal & ~AR_WA_D3_L1_DISABLE);
+ REG_WRITE(ah, AR_WA, ah->WARegVal & ~AR_WA_D3_L1_DISABLE);
}
/*
--
1.7.7
On Wed, Oct 12, 2011 at 02:50:34PM -0400, John W. Linville wrote:
> On Wed, Oct 12, 2011 at 02:40:44PM -0400, John W. Linville wrote:
> > On Mon, Oct 10, 2011 at 11:25:45AM +0530, Rajkumar Manoharan wrote:
> > > Because of not clearing Bit 14 of AR_WA, the ASPM L1 is not
> > > enabled when entering into sleep mode. AR9462 does not need
> > > bit 14 to be set.
> > >
> > > Cc: [email protected]
> > > Signed-off-by: Rajkumar Manoharan <[email protected]>
> >
> > CC [M] drivers/net/wireless/ath/ath9k/hw.o
> > drivers/net/wireless/ath/ath9k/hw.c: In function ???__ath9k_hw_init???:
> > drivers/net/wireless/ath/ath9k/hw.c:544:2: error: implicit declaration of function ???AR_SREV_9462???
> >
> > Missing a patch dependency?
>
> I see that is defined by a series posted just before that -- one that
> hasn't even appeared in wireless-next yet. Cc: [email protected]
> seems a bit inappropriate...
>
> That series needs rework anyway -- how about you just fold this one
> into that earlier series?
>
First of all sorry for the inconvenience. While splitting stable patch
from the patchset, I made it on top of patchset that caused the dependancy.
I will resend patch.
--
Rajkumar
On Mon, Oct 10, 2011 at 11:25:45AM +0530, Rajkumar Manoharan wrote:
> Because of not clearing Bit 14 of AR_WA, the ASPM L1 is not
> enabled when entering into sleep mode. AR9462 does not need
> bit 14 to be set.
>
> Cc: [email protected]
> Signed-off-by: Rajkumar Manoharan <[email protected]>
CC [M] drivers/net/wireless/ath/ath9k/hw.o
drivers/net/wireless/ath/ath9k/hw.c: In function ‘__ath9k_hw_init’:
drivers/net/wireless/ath/ath9k/hw.c:544:2: error: implicit declaration of function ‘AR_SREV_9462’
Missing a patch dependency?
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
On Wed, Oct 12, 2011 at 02:40:44PM -0400, John W. Linville wrote:
> On Mon, Oct 10, 2011 at 11:25:45AM +0530, Rajkumar Manoharan wrote:
> > Because of not clearing Bit 14 of AR_WA, the ASPM L1 is not
> > enabled when entering into sleep mode. AR9462 does not need
> > bit 14 to be set.
> >
> > Cc: [email protected]
> > Signed-off-by: Rajkumar Manoharan <[email protected]>
>
> CC [M] drivers/net/wireless/ath/ath9k/hw.o
> drivers/net/wireless/ath/ath9k/hw.c: In function ‘__ath9k_hw_init’:
> drivers/net/wireless/ath/ath9k/hw.c:544:2: error: implicit declaration of function ‘AR_SREV_9462’
>
> Missing a patch dependency?
I see that is defined by a series posted just before that -- one that
hasn't even appeared in wireless-next yet. Cc: [email protected]
seems a bit inappropriate...
That series needs rework anyway -- how about you just fold this one
into that earlier series?
John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.