2012-01-23 16:59:37

by Eliad Peller

Subject: [PATCH] compat-wireless: fix wl12xx driver-select

wl12xx is a possible choice for both group drivers and
singular modules (making it impossible to build only
the wl12xx module). change the group name to "ti" instead.

Signed-off-by: Eliad Peller <[email protected]>
---
scripts/driver-select | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/driver-select b/scripts/driver-select
index f8ca02f..540d2fe 100755
--- a/scripts/driver-select
+++ b/scripts/driver-select
@@ -56,7 +56,7 @@ function usage {
echo -e "\t${CYAN}intel${NORMAL} < ${PURPLE} iwlwifi, iwlegacy ${NORMAL}>"
echo -e "\t${CYAN}rtl818x${NORMAL} < ${PURPLE} rtl8180 rtl8187 ${NORMAL}>"
echo -e "\t${CYAN}rtlwifi${NORMAL} < ${PURPLE} rtl8192ce ${NORMAL}>"
- echo -e "\t${CYAN}wl12xx${NORMAL} < ${PURPLE} wl1251 wl12xx (SPI and SDIO)${NORMAL}>"
+ echo -e "\t${CYAN}ti${NORMAL} < ${PURPLE} wl1251 wl12xx (SPI and SDIO)${NORMAL}>"

echo -e "\nSupported group drivers: Bluetooth & Ethernet:"
echo -e "\t${CYAN}atlxx${NORMAL} < ${PURPLE} atl1 atl2 atl1e atl1c ${NORMAL}>"
@@ -348,7 +348,7 @@ case $1 in
disable_bt_usb_ethernet_var
disable_lib80211
;;
- wl12xx)
+ ti)
select_drivers CONFIG_WL1251 \
CONFIG_WL12XX
disable_staging
--
1.7.6.401.g6a319

2012-01-23 18:09:30

by Eliad Peller

Subject: Re: [PATCH] compat-wireless: fix wl12xx driver-select

On Mon, Jan 23, 2012 at 7:23 PM, Luis R. Rodriguez <[email protected]> wrote:
> On Mon, Jan 23, 2012 at 9:02 AM, Eliad Peller <[email protected]> wrote:
>> wl12xx is a possible choice for both group drivers and
>> singular modules (making it impossible to build only
>> the wl12xx module). change the group name to "ti" instead.
>>
>> Signed-off-by: Eliad Peller <[email protected]>
>> ---
>
> Is this a stable fix for linux-3.3.y branch of compat-wireless or only
> for the master branch ?
>
this is a stable fix (not very important one, though. only avoids some
redundant compilations).

Eliad.

2012-01-23 18:29:09

by Luis R. Rodriguez

Subject: Re: [PATCH] compat-wireless: fix wl12xx driver-select

On Mon, Jan 23, 2012 at 10:09 AM, Eliad Peller <[email protected]> wrote:
> On Mon, Jan 23, 2012 at 7:23 PM, Luis R. Rodriguez <[email protected]> wrote:
>> On Mon, Jan 23, 2012 at 9:02 AM, Eliad Peller <[email protected]> wrote:
>>> wl12xx is a possible choice for both group drivers and
>>> singular modules (making it impossible to build only
>>> the wl12xx module). change the group name to "ti" instead.
>>>
>>> Signed-off-by: Eliad Peller <[email protected]>
>>> ---
>>
>> Is this a stable fix for linux-3.3.y branch of compat-wireless or only
>> for the master branch ?
>>
> this is a stable fix (not very important one, though. only avoids some
> redundant compilations).

I just see this doing name changes for driver-select, how is this
fixing anything?

Luis

2012-01-23 17:23:56

by Luis R. Rodriguez

Subject: Re: [PATCH] compat-wireless: fix wl12xx driver-select

On Mon, Jan 23, 2012 at 9:02 AM, Eliad Peller <[email protected]> wrote:
> wl12xx is a possible choice for both group drivers and
> singular modules (making it impossible to build only
> the wl12xx module). change the group name to "ti" instead.
>
> Signed-off-by: Eliad Peller <[email protected]>
> ---

Is this a stable fix for linux-3.3.y branch of compat-wireless or only
for the master branch ?

Luis

2012-01-23 18:45:53

by Eliad Peller

Subject: Re: [PATCH] compat-wireless: fix wl12xx driver-select

On Mon, Jan 23, 2012 at 8:28 PM, Luis R. Rodriguez <[email protected]> wrote:
> On Mon, Jan 23, 2012 at 10:09 AM, Eliad Peller <[email protected]> wrote:
>> On Mon, Jan 23, 2012 at 7:23 PM, Luis R. Rodriguez <[email protected]> wrote:
>>> On Mon, Jan 23, 2012 at 9:02 AM, Eliad Peller <[email protected]> wrote:
>>>> wl12xx is a possible choice for both group drivers and
>>>> singular modules (making it impossible to build only
>>>> the wl12xx module). change the group name to "ti" instead.
>>>>
>>>> Signed-off-by: Eliad Peller <[email protected]>
>>>> ---
>>>
>>> Is this a stable fix for linux-3.3.y branch of compat-wireless or only
>>> for the master branch ?
>>>
>> this is a stable fix (not very important one, though. only avoids some
>> redundant compilations).
>
> I just see this doing name changes for driver-select, how is this
> fixing anything?
>
because the "switch" has 2 "cases" with the same value.
currently, "driver-select wl12xx" selects both wl12xx and wl1251
(because the first wl12xx "case" is chosen)
you can't select only wl12xx.

after this fix:
driver-select ti - selects wl12xx and wl1251
driver-select wl12xx - selects only wl12xx

Eliad.