From: Anilkumar Kolli <[email protected]>
Per peer tx stats are part of 'HTT_10_4_T2H_MSG_TYPE_PEER_STATS'
event, Firmware sends one HTT event for every four PPDUs.
HTT payload has success pkts/bytes, failed pkts/bytes, retry
pkts/bytes and rate info per ppdu.
Peer stats are enabled through 'WMI_SERVICE_PEER_STATS',
which are nowadays enabled by default.
Parse peer stats and update the tx rate information per STA.
tx rate, Peer stats are tested on QCA4019 with Firmware version
10.4-3.2.1-00028.
Signed-off-by: Anilkumar Kolli <[email protected]>
---
v2:
* address Kalle's comments
* fix compilation warnings
v3:
* fix compilation warnings (kvalo)
drivers/net/wireless/ath/ath10k/core.h | 17 ++++
drivers/net/wireless/ath/ath10k/htt.c | 2 +
drivers/net/wireless/ath/ath10k/htt.h | 25 ++++++
drivers/net/wireless/ath/ath10k/htt_rx.c | 125 ++++++++++++++++++++++++++++++
drivers/net/wireless/ath/ath10k/wmi.h | 10 ++-
5 files changed, 178 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
index e8decfaba5b6..2f324a115b18 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -337,6 +337,7 @@ struct ath10k_sta {
u32 nss;
u32 smps;
u16 peer_id;
+ struct rate_info txrate;
struct work_struct update_wk;
@@ -693,6 +694,21 @@ struct ath10k_fw_components {
struct ath10k_fw_file fw_file;
};
+struct ath10k_per_peer_tx_stats {
+ u32 succ_bytes;
+ u32 retry_bytes;
+ u32 failed_bytes;
+ u8 ratecode;
+ u8 flags;
+ u16 peer_id;
+ u16 succ_pkts;
+ u16 retry_pkts;
+ u16 failed_pkts;
+ u16 duration;
+ u32 reserved1;
+ u32 reserved2;
+};
+
struct ath10k {
struct ath_common ath_common;
struct ieee80211_hw *hw;
@@ -906,6 +922,7 @@ struct ath10k {
struct ath10k_thermal thermal;
struct ath10k_wow wow;
+ struct ath10k_per_peer_tx_stats peer_tx_stats;
/* NAPI */
struct net_device napi_dev;
diff --git a/drivers/net/wireless/ath/ath10k/htt.c b/drivers/net/wireless/ath/ath10k/htt.c
index 130cd9502021..cd160b16db1e 100644
--- a/drivers/net/wireless/ath/ath10k/htt.c
+++ b/drivers/net/wireless/ath/ath10k/htt.c
@@ -137,6 +137,8 @@
HTT_T2H_MSG_TYPE_STATS_NOUPLOAD,
[HTT_10_4_T2H_MSG_TYPE_TX_MODE_SWITCH_IND] =
HTT_T2H_MSG_TYPE_TX_MODE_SWITCH_IND,
+ [HTT_10_4_T2H_MSG_TYPE_PEER_STATS] =
+ HTT_T2H_MSG_TYPE_PEER_STATS,
};
int ath10k_htt_connect(struct ath10k_htt *htt)
diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h
index 0d2ed09f202b..164eb3a10566 100644
--- a/drivers/net/wireless/ath/ath10k/htt.h
+++ b/drivers/net/wireless/ath/ath10k/htt.h
@@ -419,6 +419,7 @@ enum htt_10_4_t2h_msg_type {
HTT_10_4_T2H_MSG_TYPE_STATS_NOUPLOAD = 0x18,
/* 0x19 to 0x2f are reserved */
HTT_10_4_T2H_MSG_TYPE_TX_MODE_SWITCH_IND = 0x30,
+ HTT_10_4_T2H_MSG_TYPE_PEER_STATS = 0x31,
/* keep this last */
HTT_10_4_T2H_NUM_MSGS
};
@@ -453,6 +454,7 @@ enum htt_t2h_msg_type {
HTT_T2H_MSG_TYPE_TX_FETCH_IND,
HTT_T2H_MSG_TYPE_TX_FETCH_CONFIRM,
HTT_T2H_MSG_TYPE_TX_MODE_SWITCH_IND,
+ HTT_T2H_MSG_TYPE_PEER_STATS,
/* keep this last */
HTT_T2H_NUM_MSGS
};
@@ -1470,6 +1472,28 @@ struct htt_channel_change {
__le32 phymode;
} __packed;
+struct htt_per_peer_tx_stats_ind {
+ __le32 succ_bytes;
+ __le32 retry_bytes;
+ __le32 failed_bytes;
+ u8 ratecode;
+ u8 flags;
+ __le16 peer_id;
+ __le16 succ_pkts;
+ __le16 retry_pkts;
+ __le16 failed_pkts;
+ __le16 tx_duration;
+ __le32 reserved1;
+ __le32 reserved2;
+} __packed;
+
+struct htt_peer_tx_stats {
+ u8 num_ppdu;
+ u8 ppdu_len;
+ u8 version;
+ u8 payload[0];
+} __packed;
+
union htt_rx_pn_t {
/* WEP: 24-bit PN */
u32 pn24;
@@ -1521,6 +1545,7 @@ struct htt_resp {
struct htt_tx_fetch_confirm tx_fetch_confirm;
struct htt_tx_mode_switch_ind tx_mode_switch_ind;
struct htt_channel_change chan_change;
+ struct htt_peer_tx_stats peer_tx_stats;
};
} __packed;
diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 285b235268d7..86d082cf4eef 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -2194,6 +2194,128 @@ void ath10k_htt_htc_t2h_msg_handler(struct ath10k *ar, struct sk_buff *skb)
dev_kfree_skb_any(skb);
}
+static inline bool is_valid_legacy_rate(u8 rate)
+{
+ static const u8 legacy_rates[] = {1, 2, 5, 11, 6, 9, 12,
+ 18, 24, 36, 48, 54};
+ int i;
+
+ for (i = 0; i < ARRAY_SIZE(legacy_rates); i++) {
+ if (rate == legacy_rates[i])
+ return true;
+ }
+
+ return false;
+}
+
+static void
+ath10k_update_per_peer_tx_stats(struct ath10k *ar,
+ struct ieee80211_sta *sta,
+ struct ath10k_per_peer_tx_stats *peer_stats)
+{
+ struct ath10k_sta *arsta = (struct ath10k_sta *)sta->drv_priv;
+ u8 rate = 0, sgi;
+ struct rate_info txrate;
+
+ lockdep_assert_held(&ar->data_lock);
+
+ txrate.flags = ATH10K_HW_PREAMBLE(peer_stats->ratecode);
+ txrate.bw = ATH10K_HW_BW(peer_stats->flags);
+ txrate.nss = ATH10K_HW_NSS(peer_stats->ratecode);
+ txrate.mcs = ATH10K_HW_MCS_RATE(peer_stats->ratecode);
+ sgi = ATH10K_HW_GI(peer_stats->flags);
+
+ if (((txrate.flags == WMI_RATE_PREAMBLE_HT) ||
+ (txrate.flags == WMI_RATE_PREAMBLE_VHT)) && txrate.mcs > 9) {
+ ath10k_warn(ar, "Invalid mcs %hhd peer stats", txrate.mcs);
+ return;
+ }
+
+ if (txrate.flags == WMI_RATE_PREAMBLE_CCK ||
+ txrate.flags == WMI_RATE_PREAMBLE_OFDM) {
+ rate = ATH10K_HW_LEGACY_RATE(peer_stats->ratecode);
+
+ if (!is_valid_legacy_rate(rate)) {
+ ath10k_warn(ar, "Invalid legacy rate %hhd peer stats",
+ rate);
+ return;
+ }
+
+ /* This is hacky, FW sends CCK rate 5.5Mbps as 6 */
+ rate *= 10;
+ if (rate == 60 && txrate.flags == WMI_RATE_PREAMBLE_CCK)
+ rate = rate - 5;
+ arsta->txrate.legacy = rate * 10;
+ } else if (txrate.flags == WMI_RATE_PREAMBLE_HT) {
+ arsta->txrate.flags = RATE_INFO_FLAGS_MCS;
+ arsta->txrate.mcs = txrate.mcs;
+ } else {
+ arsta->txrate.flags = RATE_INFO_FLAGS_VHT_MCS;
+ arsta->txrate.mcs = txrate.mcs;
+ }
+
+ if (sgi)
+ arsta->txrate.flags |= RATE_INFO_FLAGS_SHORT_GI;
+
+ arsta->txrate.nss = txrate.nss;
+ arsta->txrate.bw = txrate.bw + RATE_INFO_BW_20;
+}
+
+static void ath10k_htt_fetch_peer_stats(struct ath10k *ar,
+ struct sk_buff *skb)
+{
+ struct htt_resp *resp = (struct htt_resp *)skb->data;
+ struct ath10k_per_peer_tx_stats *p_tx_stats = &ar->peer_tx_stats;
+ struct htt_per_peer_tx_stats_ind *tx_stats;
+ struct ieee80211_sta *sta;
+ struct ath10k_peer *peer;
+ int peer_id, i;
+ u8 ppdu_len, num_ppdu;
+
+ num_ppdu = resp->peer_tx_stats.num_ppdu;
+ ppdu_len = resp->peer_tx_stats.ppdu_len * sizeof(__le32);
+
+ if (skb->len < sizeof(struct htt_resp_hdr) + num_ppdu * ppdu_len) {
+ ath10k_warn(ar, "Invalid peer stats buf length %d\n", skb->len);
+ return;
+ }
+
+ tx_stats = (struct htt_per_peer_tx_stats_ind *)
+ (resp->peer_tx_stats.payload);
+ peer_id = __le16_to_cpu(tx_stats->peer_id);
+
+ rcu_read_lock();
+ spin_lock_bh(&ar->data_lock);
+ peer = ath10k_peer_find_by_id(ar, peer_id);
+ if (!peer) {
+ ath10k_warn(ar, "Invalid peer id %d peer stats buffer\n",
+ peer_id);
+ goto out;
+ }
+
+ sta = peer->sta;
+ for (i = 0; i < num_ppdu; i++) {
+ tx_stats = (struct htt_per_peer_tx_stats_ind *)
+ (resp->peer_tx_stats.payload + i * ppdu_len);
+
+ p_tx_stats->succ_bytes = __le32_to_cpu(tx_stats->succ_bytes);
+ p_tx_stats->retry_bytes = __le32_to_cpu(tx_stats->retry_bytes);
+ p_tx_stats->failed_bytes =
+ __le32_to_cpu(tx_stats->failed_bytes);
+ p_tx_stats->ratecode = tx_stats->ratecode;
+ p_tx_stats->flags = tx_stats->flags;
+ p_tx_stats->succ_pkts = __le16_to_cpu(tx_stats->succ_pkts);
+ p_tx_stats->retry_pkts = __le16_to_cpu(tx_stats->retry_pkts);
+ p_tx_stats->failed_pkts = __le16_to_cpu(tx_stats->failed_pkts);
+
+ ath10k_update_per_peer_tx_stats(ar, sta, p_tx_stats);
+ }
+
+out:
+ spin_unlock_bh(&ar->data_lock);
+ rcu_read_unlock();
+}
+
bool ath10k_htt_t2h_msg_handler(struct ath10k *ar, struct sk_buff *skb)
{
struct ath10k_htt *htt = &ar->htt;
@@ -2354,6 +2476,9 @@ bool ath10k_htt_t2h_msg_handler(struct ath10k *ar, struct sk_buff *skb)
case HTT_T2H_MSG_TYPE_TX_MODE_SWITCH_IND:
ath10k_htt_rx_tx_mode_switch_ind(ar, skb);
break;
+ case HTT_T2H_MSG_TYPE_PEER_STATS:
+ ath10k_htt_fetch_peer_stats(ar, skb);
+ break;
case HTT_T2H_MSG_TYPE_EN_STATS:
default:
ath10k_warn(ar, "htt event (%d) not handled\n",
diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
index 1b243c899bef..e108d49998c3 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.h
+++ b/drivers/net/wireless/ath/ath10k/wmi.h
@@ -4603,9 +4603,17 @@ enum wmi_rate_preamble {
#define ATH10K_HW_NSS(rate) (1 + (((rate) >> 4) & 0x3))
#define ATH10K_HW_PREAMBLE(rate) (((rate) >> 6) & 0x3)
-#define ATH10K_HW_RATECODE(rate, nss, preamble) \
+#define ATH10K_HW_MCS_RATE(rate) ((rate) & 0xf)
+#define ATH10K_HW_LEGACY_RATE(rate) ((rate) & 0x3f)
+#define ATH10K_HW_BW(flags) (((flags) >> 3) & 0x3)
+#define ATH10K_HW_GI(flags) (((flags) >> 5) & 0x1)
+#define ATH10K_HW_RATECODE(rate, nss, preamble) \
(((preamble) << 6) | ((nss) << 4) | (rate))
+#define VHT_MCS_NUM 10
+#define VHT_BW_NUM 4
+#define VHT_NSS_NUM 4
+
/* Value to disable fixed rate setting */
#define WMI_FIXED_RATE_NONE (0xff)
--
1.7.9.5
[email protected] wrote:
> From: Anilkumar Kolli <[email protected]>
>
> Per peer tx stats are part of 'HTT_10_4_T2H_MSG_TYPE_PEER_STATS'
> event, Firmware sends one HTT event for every four PPDUs.
> HTT payload has success pkts/bytes, failed pkts/bytes, retry
> pkts/bytes and rate info per ppdu.
> Peer stats are enabled through 'WMI_SERVICE_PEER_STATS',
> which are nowadays enabled by default.
>
> Parse peer stats and update the tx rate information per STA.
>
> tx rate, Peer stats are tested on QCA4019 with Firmware version
> 10.4-3.2.1-00028.
>
> Signed-off-by: Anilkumar Kolli <[email protected]>
2 patches applied to ath-next branch of ath.git, thanks.
cec17c382140 ath10k: add per peer htt tx stats support for 10.4
5608eaf7b086 ath10k: add support for per sta tx bitrate
--
https://patchwork.kernel.org/patch/9430197/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
On Dienstag, 15. November 2016 22:07:29 CEST [email protected] wrote:
> From: Anilkumar Kolli <[email protected]>
>
> Per peer tx stats are part of 'HTT_10_4_T2H_MSG_TYPE_PEER_STATS'
> event, Firmware sends one HTT event for every four PPDUs.
> HTT payload has success pkts/bytes, failed pkts/bytes, retry
> pkts/bytes and rate info per ppdu.
> Peer stats are enabled through 'WMI_SERVICE_PEER_STATS',
> which are nowadays enabled by default.
>
> Parse peer stats and update the tx rate information per STA.
>
> tx rate, Peer stats are tested on QCA4019 with Firmware version
> 10.4-3.2.1-00028.
>
> Signed-off-by: Anilkumar Kolli <[email protected]>
> ---
Just played a little bit around with it and an 802.11n client (2x2x). The
thing I've observed was that MCS 0-7 was reported as MCS rate but the client
received mostly MCS 8-15.
Guessing from this section
> if (((txrate.flags == WMI_RATE_PREAMBLE_HT) ||
> (txrate.flags == WMI_RATE_PREAMBLE_VHT)) && txrate.mcs > 9) {
> ath10k_warn(ar, "Invalid mcs %hhd peer stats", txrate.mcs);
> return;
> }
it looks like HT rates are reported as 0-9 with an NSS setting (yes, as odd as
this is). I've printed the values to check it:
[ 68.529197] XXXXX txrate.flags 2, txrate.bw 1, txrate.nss 2, txrate.mcs 5
[ 68.529500] XXXXX txrate.flags 2, txrate.bw 1, txrate.nss 2, txrate.mcs 4
[ 68.535225] XXXXX txrate.flags 2, txrate.bw 1, txrate.nss 2, txrate.mcs 4
[ 68.542290] XXXXX txrate.flags 2, txrate.bw 1, txrate.nss 2, txrate.mcs 4
[ 68.549507] XXXXX txrate.flags 2, txrate.bw 1, txrate.nss 2, txrate.mcs 4
[ 68.555627] XXXXX txrate.flags 2, txrate.bw 1, txrate.nss 2, txrate.mcs 4
[ 68.562652] XXXXX txrate.flags 2, txrate.bw 1, txrate.nss 2, txrate.mcs 4
I don't know this for sure but my next guess is now that following change is
missing:
@@ -2231,8 +2231,10 @@ ath10k_update_per_peer_tx_stats(struct ath10k *ar,
sgi = ATH10K_HW_GI(peer_stats->flags);
if (((txrate.flags == WMI_RATE_PREAMBLE_HT) ||
- (txrate.flags == WMI_RATE_PREAMBLE_VHT)) && txrate.mcs > 9) {
- ath10k_warn(ar, "Invalid mcs %hhd peer stats", txrate.mcs);
+ (txrate.flags == WMI_RATE_PREAMBLE_VHT)) &&
+ (txrate.mcs > 9 || txrate.nss < 1)) {
+ ath10k_warn(ar, "Invalid mcs %hhd nss %hhd peer stats",
+ txrate.mcs, txrate.nss);
return;
}
@@ -2255,7 +2257,7 @@ ath10k_update_per_peer_tx_stats(struct ath10k *ar,
arsta->txrate.legacy = rate;
} else if (txrate.flags == WMI_RATE_PREAMBLE_HT) {
arsta->txrate.flags = RATE_INFO_FLAGS_MCS;
- arsta->txrate.mcs = txrate.mcs;
+ arsta->txrate.mcs = txrate.mcs + 8 * (txrate.nss - 1);
} else {
arsta->txrate.flags = RATE_INFO_FLAGS_VHT_MCS;
arsta->txrate.mcs = txrate.mcs;
Funny enough, I was spamming following with my 802.11n!!!! 2x2 client:
[ 115.694987] XXXXX txrate.flags 3, txrate.bw 1, txrate.nss 4, txrate.mcs 15
[ 115.701851] ath10k_ahb a800000.wifi: Invalid mcs 15 peer stats
Firmware was 10.4-3.2.1-00050 on an Dakota (IPQ401X) board.
Kind regards,
Sven
On Dienstag, 21. November 2017 09:00:54 CET Sebastian Gottschall wrote:
[...]
> >> Why is the support for 10.2.4 firmware not upstreamed? I mean the one which is
> >> using pktlog to transfer the PEER_STATS information.
> > I'm not sure what you are asking. If you are asking the firmware release
> > mentioned in the commit log that's in ath10k-firmware:
> >
> > https://github.com/kvalo/ath10k-firmware/tree/master/QCA4019/hw1.0/3.2.1
> >
> > But I'm sure you know that already.
>
> i believe he is just talking about a patch which allows to get station
> statistics like rx and tx rate on the firmare 10.2 series which is
> qca988x mainly
>
> this patch was posted here months ago but never got upstream
Yes, I was talking about that patch (which I didn't find on the mailing list -
so a link would be helpful). QCA is gathering a lot of patches (a00-*) at
https://source.codeaurora.org/quic/qsdk/oss/system/feeds/wlan-open/tree/mac80211/patches?h=coconut
which are often not upstreamed. The patch
a00-0075-ath10k-Add-support-to-parse-per-station-tx-stats-for.patch is the one
which is receiving the TX statistics stuff from 10.2.
I had a discussion with some QCA employee (or actually OpenMesh had it and I
joined the discussion rather late) where the QCA employee was very confident
that ath10k supports ATH10K_PKTLOG_PEER_STATS (not the fw_stats stuff in
debugfs). But I couldn't find the code for that in ath10k. Only after some
guesswork, I was able to find the patch mentioned above and was able to test
it (after hacking the smart antenna patch dependency away).
Kind regards,
Sven
Sven Eckelmann <[email protected]> writes:
> On Dienstag, 15. November 2016 22:07:29 CET [email protected] wrote=
:
>> From: Anilkumar Kolli <[email protected]>
>>=20
>> Per peer tx stats are part of 'HTT_10_4_T2H_MSG_TYPE_PEER_STATS'
>> event, Firmware sends one HTT event for every four PPDUs.
>> HTT payload has success pkts/bytes, failed pkts/bytes, retry
>> pkts/bytes and rate info per ppdu.
>> Peer stats are enabled through 'WMI_SERVICE_PEER_STATS',
>> which are nowadays enabled by default.
>>=20
>> Parse peer stats and update the tx rate information per STA.
>>=20
>> tx rate, Peer stats are tested on QCA4019 with Firmware version
>> 10.4-3.2.1-00028.
>>=20
>> Signed-off-by: Anilkumar Kolli <[email protected]>
>
> Why is the support for 10.2.4 firmware not upstreamed? I mean the one whi=
ch is=20
> using pktlog to transfer the PEER_STATS information.
I'm not sure what you are asking. If you are asking the firmware release
mentioned in the commit log that's in ath10k-firmware:
https://github.com/kvalo/ath10k-firmware/tree/master/QCA4019/hw1.0/3.2.1
But I'm sure you know that already.
--=20
Kalle Valo=
On Dienstag, 15. November 2016 22:07:29 CET [email protected] wrote:
> From: Anilkumar Kolli <[email protected]>
>
> Per peer tx stats are part of 'HTT_10_4_T2H_MSG_TYPE_PEER_STATS'
> event, Firmware sends one HTT event for every four PPDUs.
> HTT payload has success pkts/bytes, failed pkts/bytes, retry
> pkts/bytes and rate info per ppdu.
> Peer stats are enabled through 'WMI_SERVICE_PEER_STATS',
> which are nowadays enabled by default.
>
> Parse peer stats and update the tx rate information per STA.
>
> tx rate, Peer stats are tested on QCA4019 with Firmware version
> 10.4-3.2.1-00028.
>
> Signed-off-by: Anilkumar Kolli <[email protected]>
Why is the support for 10.2.4 firmware not upstreamed? I mean the one which is
using pktlog to transfer the PEER_STATS information.
Kind regards,
Sven
Sebastian Gottschall <[email protected]> writes:
> Am 21.11.2017 um 08:58 schrieb Kalle Valo:
>> Sven Eckelmann <[email protected]> writes:
>>
>>> On Dienstag, 15. November 2016 22:07:29 CET [email protected] wro=
te:
>>>> From: Anilkumar Kolli <[email protected]>
>>>>
>>>> Per peer tx stats are part of 'HTT_10_4_T2H_MSG_TYPE_PEER_STATS'
>>>> event, Firmware sends one HTT event for every four PPDUs.
>>>> HTT payload has success pkts/bytes, failed pkts/bytes, retry
>>>> pkts/bytes and rate info per ppdu.
>>>> Peer stats are enabled through 'WMI_SERVICE_PEER_STATS',
>>>> which are nowadays enabled by default.
>>>>
>>>> Parse peer stats and update the tx rate information per STA.
>>>>
>>>> tx rate, Peer stats are tested on QCA4019 with Firmware version
>>>> 10.4-3.2.1-00028.
>>>>
>>>> Signed-off-by: Anilkumar Kolli <[email protected]>
>>> Why is the support for 10.2.4 firmware not upstreamed? I mean the one w=
hich is
>>> using pktlog to transfer the PEER_STATS information.
>> I'm not sure what you are asking. If you are asking the firmware release
>> mentioned in the commit log that's in ath10k-firmware:
>>
>> https://github.com/kvalo/ath10k-firmware/tree/master/QCA4019/hw1.0/3.2.1
>>
>> But I'm sure you know that already.
>
> i believe he is just talking about a patch which allows to get station
> statistics like rx and tx rate on the firmare 10.2 series which is
> qca988x mainly
>
> this patch was posted here months ago but never got upstream
Any pointers to the patch? Patch title or link to patchwork would help.
I see hundreds of patches per release, I cannot remember all of them.
--=20
Kalle Valo=
maybe this one?
i have this qca988x supporting tx/rx rate patch in my local tree. just
need to extract it again
ath10k: report per-station tx/rate rates to mac80211
Am 21.11.2017 um 09:40 schrieb Kalle Valo:
> Sven Eckelmann <[email protected]> writes:
>
>> On Dienstag, 21. November 2017 09:00:54 CET Sebastian Gottschall wrote:
>> [...]
>>>>> Why is the support for 10.2.4 firmware not upstreamed? I mean the one which is
>>>>> using pktlog to transfer the PEER_STATS information.
>>>> I'm not sure what you are asking. If you are asking the firmware release
>>>> mentioned in the commit log that's in ath10k-firmware:
>>>>
>>>> https://github.com/kvalo/ath10k-firmware/tree/master/QCA4019/hw1.0/3.2.1
>>>>
>>>> But I'm sure you know that already.
>>> i believe he is just talking about a patch which allows to get station
>>> statistics like rx and tx rate on the firmare 10.2 series which is
>>> qca988x mainly
>>>
>>> this patch was posted here months ago but never got upstream
>> Yes, I was talking about that patch (which I didn't find on the
>> mailing list - so a link would be helpful). QCA is gathering a lot of
>> patches (a00-*) at
>> https://source.codeaurora.org/quic/qsdk/oss/system/feeds/wlan-open/tree/mac80211/patches?h=coconut
>> which are often not upstreamed.
> Oh, that. I have always told the team working on that repository that
> they should upstream everything but obviously they don't :/
>
>> The patch
>> a00-0075-ath10k-Add-support-to-parse-per-station-tx-stats-for.patch is
>> the one which is receiving the TX statistics stuff from 10.2.
> I tried to find that patch from the ath10k list archives but didn't find
> it. I only did a quick search so of course it might be submitted still,
> so if anyone finds a link please let me know.
>
--
Mit freundlichen Grüssen / Regards
Sebastian Gottschall / CTO
NewMedia-NET GmbH - DD-WRT
Firmensitz: Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: [email protected]
Tel.: +496251-582650 / Fax: +496251-5826565
Am 21.11.2017 um 08:58 schrieb Kalle Valo:
> Sven Eckelmann <[email protected]> writes:
>
>> On Dienstag, 15. November 2016 22:07:29 CET [email protected] wrote:
>>> From: Anilkumar Kolli <[email protected]>
>>>
>>> Per peer tx stats are part of 'HTT_10_4_T2H_MSG_TYPE_PEER_STATS'
>>> event, Firmware sends one HTT event for every four PPDUs.
>>> HTT payload has success pkts/bytes, failed pkts/bytes, retry
>>> pkts/bytes and rate info per ppdu.
>>> Peer stats are enabled through 'WMI_SERVICE_PEER_STATS',
>>> which are nowadays enabled by default.
>>>
>>> Parse peer stats and update the tx rate information per STA.
>>>
>>> tx rate, Peer stats are tested on QCA4019 with Firmware version
>>> 10.4-3.2.1-00028.
>>>
>>> Signed-off-by: Anilkumar Kolli <[email protected]>
>> Why is the support for 10.2.4 firmware not upstreamed? I mean the one which is
>> using pktlog to transfer the PEER_STATS information.
> I'm not sure what you are asking. If you are asking the firmware release
> mentioned in the commit log that's in ath10k-firmware:
>
> https://github.com/kvalo/ath10k-firmware/tree/master/QCA4019/hw1.0/3.2.1
>
> But I'm sure you know that already.
i believe he is just talking about a patch which allows to get station
statistics like rx and tx rate on the firmare 10.2 series which is
qca988x mainly
this patch was posted here months ago but never got upstream
>
--
Mit freundlichen Grüssen / Regards
Sebastian Gottschall / CTO
NewMedia-NET GmbH - DD-WRT
Firmensitz: Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: [email protected]
Tel.: +496251-582650 / Fax: +496251-5826565
Sven Eckelmann <[email protected]> writes:
> On Dienstag, 21. November 2017 09:00:54 CET Sebastian Gottschall wrote:
> [...]
>> >> Why is the support for 10.2.4 firmware not upstreamed? I mean the one=
which is
>> >> using pktlog to transfer the PEER_STATS information.
>> > I'm not sure what you are asking. If you are asking the firmware relea=
se
>> > mentioned in the commit log that's in ath10k-firmware:
>> >
>> > https://github.com/kvalo/ath10k-firmware/tree/master/QCA4019/hw1.0/3.2=
.1
>> >
>> > But I'm sure you know that already.
>>=20
>> i believe he is just talking about a patch which allows to get station=20
>> statistics like rx and tx rate on the firmare 10.2 series which is=20
>> qca988x mainly
>>=20
>> this patch was posted here months ago but never got upstream
>
> Yes, I was talking about that patch (which I didn't find on the
> mailing list - so a link would be helpful). QCA is gathering a lot of
> patches (a00-*) at
> https://source.codeaurora.org/quic/qsdk/oss/system/feeds/wlan-open/tree/m=
ac80211/patches?h=3Dcoconut
> which are often not upstreamed.
Oh, that. I have always told the team working on that repository that
they should upstream everything but obviously they don't :/
> The patch
> a00-0075-ath10k-Add-support-to-parse-per-station-tx-stats-for.patch is
> the one which is receiving the TX statistics stuff from 10.2.
I tried to find that patch from the ath10k list archives but didn't find
it. I only did a quick search so of course it might be submitted still,
so if anyone finds a link please let me know.
--=20
Kalle Valo=
On Dienstag, 21. November 2017 10:00:20 CET Sebastian Gottschall wrote:
> maybe this one?
>
> i have this qca988x supporting tx/rx rate patch in my local tree. just
> need to extract it again
>
> ath10k: report per-station tx/rate rates to mac80211
This one sounds like https://patchwork.kernel.org/patch/8597341/ - and it is
something different (end is implementing get_expected_throughput "wrong" and
therefore overestimates the expected throughput extremely). This patch is
using the stuff from fw_stats to fill the station rx/tx information.
It is not the worst thing to do (I want(ed) to use something similar for my
purposes) but there is a special pktlog message on 10.2 which contains the
same information as the 10.4 HTT_10_4_T2H_MSG_TYPE_PEER_STATS.
Kind regards,
Sven