From: Venkat Prashanth B U <[email protected]>
Prefer and make it generic by using %s and __func__
to print function name
Change Log:
v2:
a. RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE, "\n");
The function name is not necessary in above code
according to conditions as mentioned in comments.
b. modified the commit message according
to suggested comments.
c. fixed the alignment issues.
v1:
a. Sign-off line is saperated from subject
line from earlier patch version.
Signed-off-by: Venkat Prashanth B U <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c
index f713c72..09c4e14 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c
@@ -389,7 +389,7 @@ void rtl8723e_tx_fill_desc(struct ieee80211_hw *hw,
if (pci_dma_mapping_error(rtlpci->pdev, mapping)) {
RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,
- "DMA mapping error\n");
+ "%s():DMA mapping error\n", __func__);
return;
}
if (mac->opmode == NL80211_IFTYPE_STATION) {
@@ -498,7 +498,7 @@ void rtl8723e_tx_fill_desc(struct ieee80211_hw *hw,
if (ieee80211_is_data_qos(fc)) {
if (mac->rdg_en) {
RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,
- "Enable RDG function.\n");
+ "%s():Enable RDG function.\n", __func__);
SET_TX_DESC_RDG_ENABLE(pdesc, 1);
SET_TX_DESC_HTC(pdesc, 1);
}
@@ -557,7 +557,7 @@ void rtl8723e_tx_fill_cmddesc(struct ieee80211_hw *hw,
if (pci_dma_mapping_error(rtlpci->pdev, mapping)) {
RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,
- "DMA mapping error\n");
+ "%s():DMA mapping error\n", __func__);
return;
}
CLEAR_PCI_TX_DESC_CONTENT(pdesc, TX_DESC_SIZE);
--
1.9.1
On Fri, Nov 24, 2017 at 05:11:20PM +0530, [email protected] wrote:
> From: Venkat Prashanth B U <[email protected]>
>
> Prefer and make it generic by using %s and __func__
> to print function name
>
> Change Log:
>
> v2:
> a. RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE, "\n");
> The function name is not necessary in above code
> according to conditions as mentioned in comments.
>
> b. modified the commit message according
> to suggested comments.
>
> c. fixed the alignment issues.
>
> v1:
> a. Sign-off line is saperated from subject
> line from earlier patch version.
>
> Signed-off-by: Venkat Prashanth B U <[email protected]>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c | 6 +++---
Why are you sending me this patch???
confused,
greg k-h
On 11/24/2017 05:41 AM, [email protected] wrote:
> From: Venkat Prashanth B U <[email protected]>
>
> Prefer and make it generic by using %s and __func__
> to print function name
>
> Change Log:
>
> v2:
> a. RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE, "\n");
> The function name is not necessary in above code
> according to conditions as mentioned in comments.
>
> b. modified the commit message according
> to suggested comments.
>
> c. fixed the alignment issues.
>
> v1:
> a. Sign-off line is saperated from subject
> line from earlier patch version.
>
> Signed-off-by: Venkat Prashanth B U <[email protected]> > ---
Please read the documentation on submitting a patch. In the present format, the
change log becomes part of the permanent commit. Generating patches is a lot
like make sausage. No one wants the details. Place any information you want
known to the maintainer and reviewers beneath the --- divider, and follow it
with another divider. Such info is available to interested parties, but will be
stripped out when the patch is commited.
In addition, your commit message does not accurately describe the change.
I hope you remove GregKH from any wireless patches that are NOT in staging!
NACK
Larry
> drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c
> index f713c72..09c4e14 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c
> @@ -389,7 +389,7 @@ void rtl8723e_tx_fill_desc(struct ieee80211_hw *hw,
>
> if (pci_dma_mapping_error(rtlpci->pdev, mapping)) {
> RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,
> - "DMA mapping error\n");
> + "%s():DMA mapping error\n", __func__);
> return;
> }
> if (mac->opmode == NL80211_IFTYPE_STATION) {
> @@ -498,7 +498,7 @@ void rtl8723e_tx_fill_desc(struct ieee80211_hw *hw,
> if (ieee80211_is_data_qos(fc)) {
> if (mac->rdg_en) {
> RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,
> - "Enable RDG function.\n");
> + "%s():Enable RDG function.\n", __func__);
> SET_TX_DESC_RDG_ENABLE(pdesc, 1);
> SET_TX_DESC_HTC(pdesc, 1);
> }
> @@ -557,7 +557,7 @@ void rtl8723e_tx_fill_cmddesc(struct ieee80211_hw *hw,
>
> if (pci_dma_mapping_error(rtlpci->pdev, mapping)) {
> RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,
> - "DMA mapping error\n");
> + "%s():DMA mapping error\n", __func__);
> return;
> }
> CLEAR_PCI_TX_DESC_CONTENT(pdesc, TX_DESC_SIZE);
> --
> 1.9.1
>
>