The return value from devm_memremap() is not checked correctly.
The test is done against a wrong variable. This patch fix it.
Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/net/wireless/ath/ath10k/qmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c
index 56cb183..c2cbb41 100644
--- a/drivers/net/wireless/ath/ath10k/qmi.c
+++ b/drivers/net/wireless/ath/ath10k/qmi.c
@@ -931,7 +931,7 @@ static int ath10k_qmi_setup_msa_resources(struct ath10k_qmi *qmi, u32 msa_size)
qmi->msa_mem_size = resource_size(&r);
qmi->msa_va = devm_memremap(dev, qmi->msa_pa, qmi->msa_mem_size,
MEMREMAP_WT);
- if (!qmi->msa_pa) {
+ if (!qmi->msa_va) {
dev_err(dev, "failed to map memory region: %pa\n", &r.start);
return -EBUSY;
}
Wei Yongjun <[email protected]> writes:
> The return value from devm_memremap() is not checked correctly.
> The test is done against a wrong variable. This patch fix it.
>
> Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
> Signed-off-by: Wei Yongjun <[email protected]>
Please don't mark wireless patches for net-next, by default ath10k
patches go to ath-next branch of my ath.git tree. But no need to resend
because of this.
--
Kalle Valo
Wei Yongjun <[email protected]> wrote:
> The return value from devm_memremap() is not checked correctly.
> The test is done against a wrong variable. This patch fix it.
>
> Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client")
> Signed-off-by: Wei Yongjun <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
4ab7fd955e47 ath10k: fix copy-paste error in ath10k_qmi_setup_msa_resources()
--
https://patchwork.kernel.org/patch/10642589/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches