2021-01-12 11:53:01

by Abaci Team

Subject: [PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison

Fix the following coccicheck warning:
./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17:
WARNING: Comparison of 0/1 to bool variable

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: YANG LI <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
index 372d6f8..1fb857c 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
@@ -3848,7 +3848,7 @@ static void _rtl8821ae_iqk_tx(struct ieee80211_hw *hw, enum radio_path path)
else
rtl_write_dword(rtlpriv, 0xc8c, 0x00163e96);

- if (vdf_enable == 1) {
+ if (vdf_enable) {
rtl_dbg(rtlpriv, COMP_IQK, DBG_LOUD, "VDF_enable\n");
for (k = 0; k <= 2; k++) {
switch (k) {
--
1.8.3.1

2021-01-12 13:23:36

by Ping-Ke Shih

Subject: Re: [PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison

On Tue, 2021-01-12 at 16:33 +0800, YANG LI wrote:
> Fix the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17:
> WARNING: Comparison of 0/1 to bool variable
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: YANG LI <[email protected]>
>

I think your name of Signed-off-by should be "Yang Li".

And, the subject prefix "rtlwifi: " is preferred.

---
Ping-Ke

2021-01-12 15:49:33

by Kalle Valo

Subject: Re: [PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison

Pkshih <[email protected]> writes:

> On Tue, 2021-01-12 at 16:33 +0800, YANG LI wrote:
>> Fix the following coccicheck warning:
>> ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17:
>> WARNING: Comparison of 0/1 to bool variable
>>
>> Reported-by: Abaci Robot <[email protected]>
>> Signed-off-by: YANG LI <[email protected]>
>>
>
> I think your name of Signed-off-by should be "Yang Li".
>
> And, the subject prefix "rtlwifi: " is preferred.

I can fix those during commit.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches