2022-01-11 07:15:09

by Dan Carpenter

Subject: [PATCH] ath11k: fix error code in ath11k_qmi_assign_target_mem_chunk()

The "ret" vairable is not set at this point. It could be uninitialized
or zero. The correct thing to return is -ENODEV.

Fixes: 6ac04bdc5edb ("ath11k: Use reserved host DDR addresses from DT for PCI devices")
Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/net/wireless/ath/ath11k/qmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c
index 65d3c6ba35ae..cf9f4ba75e03 100644
--- a/drivers/net/wireless/ath/ath11k/qmi.c
+++ b/drivers/net/wireless/ath/ath11k/qmi.c
@@ -1932,7 +1932,7 @@ static int ath11k_qmi_assign_target_mem_chunk(struct ath11k_base *ab)
if (!hremote_node) {
ath11k_dbg(ab, ATH11K_DBG_QMI,
"qmi fail to get hremote_node\n");
- return ret;
+ return -ENODEV;
}

ret = of_address_to_resource(hremote_node, 0, &res);
--
2.20.1

2022-01-18 02:24:23

by Kalle Valo

Subject: Re: [PATCH] ath11k: fix error code in ath11k_qmi_assign_target_mem_chunk()

Dan Carpenter <[email protected]> wrote:

> The "ret" vairable is not set at this point. It could be uninitialized
> or zero. The correct thing to return is -ENODEV.
>
> Fixes: 6ac04bdc5edb ("ath11k: Use reserved host DDR addresses from DT for PCI devices")
> Signed-off-by: Dan Carpenter <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

c9b41832dc08 ath11k: fix error code in ath11k_qmi_assign_target_mem_chunk()

--
https://patchwork.kernel.org/project/linux-wireless/patch/20220111071445.GA11243@kili/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches