Mahmoud Maatuq <[email protected]> wrote:
> coccinielle reported the following:
> ./drivers/net/wireless/ath/ath5k/phy.c:1573:25-26: WARNING opportunity for swap()
>
> while trying to fix the above warning, it reveals that ath5k_hw_get_median_noise_floor()
> had open-coded sort() functionality. Since ath5k_hw_get_median_noise_floor() only
> executes once every 10 seconds, any extra overhead due to sort() calling
> its "compare" and "swap" functions can be ignored, so replace the
> existing logic with a call to sort().
>
> Signed-off-by: Mahmoud Maatuq <[email protected]>
> Suggested-by: Jiri Slaby <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
e10ec6ea612c wifi: ath5k: ath5k_hw_get_median_noise_floor(): use swap()
--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches