2023-08-14 13:03:20

by Jinjie Ruan

Subject: [PATCH net-next 1/2] wifi: ath: Use is_multicast_ether_addr() to check multicast Ether address

Use is_multicast_ether_addr() to perform the Checking.

Signed-off-by: Ruan Jinjie <[email protected]>
---
drivers/net/wireless/ath/key.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/key.c b/drivers/net/wireless/ath/key.c
index b7b61d4f02ba..21a93fec284d 100644
--- a/drivers/net/wireless/ath/key.c
+++ b/drivers/net/wireless/ath/key.c
@@ -104,7 +104,7 @@ bool ath_hw_keysetmac(struct ath_common *common, u16 entry, const u8 *mac)
* Not setting this bit allows the hardware to use the key
* for multicast frame decryption.
*/
- if (mac[0] & 0x01)
+ if (is_multicast_ether_addr(mac))
unicast_flag = 0;

macLo = get_unaligned_le32(mac);
--
2.34.1

2023-08-14 15:03:26

by Jeff Johnson

Subject: Re: [PATCH net-next 1/2] wifi: ath: Use is_multicast_ether_addr() to check multicast Ether address

On 8/14/2023 5:42 AM, Ruan Jinjie wrote:
> Use is_multicast_ether_addr() to perform the Checking.
>
> Signed-off-by: Ruan Jinjie <[email protected]>

Reviewed-by: Jeff Johnson <[email protected]>

> ---
> drivers/net/wireless/ath/key.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/key.c b/drivers/net/wireless/ath/key.c
> index b7b61d4f02ba..21a93fec284d 100644
> --- a/drivers/net/wireless/ath/key.c
> +++ b/drivers/net/wireless/ath/key.c
> @@ -104,7 +104,7 @@ bool ath_hw_keysetmac(struct ath_common *common, u16 entry, const u8 *mac)
> * Not setting this bit allows the hardware to use the key
> * for multicast frame decryption.
> */
> - if (mac[0] & 0x01)
> + if (is_multicast_ether_addr(mac))
> unicast_flag = 0;
>
> macLo = get_unaligned_le32(mac);

2023-08-25 08:45:31

by Kalle Valo

Subject: Re: [PATCH net-next 1/2] wifi: ath: Use is_multicast_ether_addr() to check multicast Ether address

Ruan Jinjie <[email protected]> wrote:

> Use is_multicast_ether_addr() to perform the Checking.
>
> Signed-off-by: Ruan Jinjie <[email protected]>
> Reviewed-by: Jeff Johnson <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

4c2964ef553b wifi: ath: Use is_multicast_ether_addr() to check multicast Ether address

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches