2023-09-07 18:22:20

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH v2] ssb: Fix division by zero issue in ssb_calc_clock_rate

Rand Deeb <[email protected]> wrote:

> In ssb_calc_clock_rate(), there is a potential issue where the value of
> m1 could be zero due to initialization using clkfactor_f6_resolv(). This
> situation raised concerns about the possibility of a division by zero
> error.
>
> We fixed it by following the suggestions provided by Larry Finger
> <[email protected]> and Michael Büsch <[email protected]>. The fix
> involves returning a value of 1 instead of 0 in clkfactor_f6_resolv().
> This modification ensures the proper functioning of the code and
> eliminates the risk of division by zero errors.
>
> Signed-off-by: Rand Deeb <[email protected]>
> Acked-by: Larry Finger <[email protected]>
> Acked-by: Michael Büsch <[email protected]>

Patch applied to wireless-next.git, thanks.

e0b5127fa134 ssb: Fix division by zero issue in ssb_calc_clock_rate

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches