2023-09-28 15:19:10

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] [v2] wifi: ath11k: fix ath11k_mac_op_remain_on_channel() stack usage

Dmitry Antipov <[email protected]> wrote:

> When compiling with clang 16.0.6, I've noticed the following:
>
> drivers/net/wireless/ath/ath11k/mac.c:8903:12: warning: stack frame
> size (1032) exceeds limit (1024) in 'ath11k_mac_op_remain_on_channel'
> [-Wframe-larger-than]
> static int ath11k_mac_op_remain_on_channel(struct ieee80211_hw *hw,
> ^
> 68/1032 (6.59%) spills, 964/1032 (93.41%) variables
>
> So switch to kzalloc()'ed instance of 'struct scan_req_params' like
> it's done in 'ath11k_mac_op_hw_scan()'. Compile tested only.
>
> Signed-off-by: Dmitry Antipov <[email protected]>
> Acked-by: Jeff Johnson <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

4fd15bb705d3 wifi: ath11k: fix ath11k_mac_op_remain_on_channel() stack usage

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches