I've been threatening to do this for a while. Since I've recently
pulled from everyone, the incoming patch rate is slow this week,
and we are getting close to being in -mm, now seems as good a time
as any to do it...
I've changed all references in wireless-dev from d80211 to mac80211
and from D80211 to MAC80211, including renaming files and directories
appropriately. If you have outstanding patches, please account for
this change. Filtering them through sed should do the job nicely:
cat old.patch | sed -e 's/d80211/mac80211/g' \
-e 's/D80211/MAC80211/g' > new.patch
I don't think it would have been appropriate to keep the old name,
with its veiled reference to its origin but no real meaning to the
uninitiated. I think the mac80211 name is more indicative of the
component's function, and it matches the naming motif we are using
for cfg80211 and nl80211.
I apologize if this seems sudden, but I don't really think doing
it with a lot of warning would have been any better. So, I made
the decision and did it. Please don't complain unless it is just
unbearable for you. :-)
The patch has been pushed to wireless-dev, and hopefully will be
available by the time you read this.
Thanks,
John
P.S. The actual patch is too large to post here. It is available
on http://www.kernel.org:
http://www.kernel.org/pub/linux/kernel/people/linville/wireless-dev/master/0738-wireless-rename-d80211-mac80211.patch
--
John W. Linville
[email protected]
On Mon, 2007-02-26 at 22:27 -0500, John W. Linville wrote:
> I've changed all references in wireless-dev from d80211 to mac80211
> and from D80211 to MAC80211,
And I notice that by "all references", you really mean it:
-T: git kernel.org:/pub/scm/linux/kernel/git/mwu/d80211-drivers.git
+T: git kernel.org:/pub/scm/linux/kernel/git/mwu/mac80211-drivers.git
johannes
On Mon, 26 Feb 2007 22:27:57 -0500, John W. Linville wrote:
> I apologize if this seems sudden, but I don't really think doing
> it with a lot of warning would have been any better. So, I made
> the decision and did it. Please don't complain unless it is just
> unbearable for you. :-)
I think it's indeed a good time for such change now. Thanks for doing that!
When we are at it, I think the module name should be 'mac80211.ko' and not
'80211.ko'. This means renaming of mac80211.c (I suggest mac80211_proto.c or
mac80211_main.c). Does it sounds reasonable? Should I make a patch?
Thanks,
Jiri
--
Jiri Benc
SUSE Labs
On Tuesday 27 February 2007 08:16, John W. Linville wrote:
> Michael, any chance you'd like to rename your tree so as to preserve
> my infallibility? :-)
>
Done.
-Michael Wu
On Tue, 2007-02-27 at 11:28 +0100, Jiri Benc wrote:
> When we are at it, I think the module name should be 'mac80211.ko' and not
> '80211.ko'. This means renaming of mac80211.c (I suggest mac80211_proto.c or
> mac80211_main.c). Does it sounds reasonable? Should I make a patch?
This has bothered me for long. Can't we just call it main.c? I mean,
it's in mac80211/main.c so there's no chance of confusion... What's the
point in having mac80211/mac80211_something.c?
johannes
On Tue, Feb 27, 2007 at 11:56:35AM +0100, Johannes Berg wrote:
> On Mon, 2007-02-26 at 22:27 -0500, John W. Linville wrote:
>
> > I've changed all references in wireless-dev from d80211 to mac80211
> > and from D80211 to MAC80211,
>
> And I notice that by "all references", you really mean it:
>
> -T: git kernel.org:/pub/scm/linux/kernel/git/mwu/d80211-drivers.git
> +T: git kernel.org:/pub/scm/linux/kernel/git/mwu/mac80211-drivers.git
Well, that may have been a bit unintentional. Still, it might be
appropriate...
Michael, any chance you'd like to rename your tree so as to preserve
my infallibility? :-)
John
--
John W. Linville
[email protected]
On Tue, 27 Feb 2007 11:39:06 +0100, Johannes Berg wrote:
> This has bothered me for long. Can't we just call it main.c? I mean,
> it's in mac80211/main.c so there's no chance of confusion... What's the
> point in having mac80211/mac80211_something.c?
Fine with me.
Jiri
--
Jiri Benc
SUSE Labs