> -What: iee80211 softmac wireless networking component
> +What: ieee80211 softmac wireless networking component
Unrelated change, please separate.
> +
> +What: rc80211-simple rate control algorithm for mac80211
> +When: 2.6.26
> +Files: net/mac80211/rc80211-simple.c
> +Why: This algorithm was provided for reference but always exhibited bad
> + responsiveness and performance and has some serious flaws. It has been
> + replaced by rc80211-pid.
> +Who: Stefano Brivio <[email protected]>
I don't think we really want to do this. We can't even change the
algorithm anyway except by recompiling with a different default.
Will do a code review tomorrow.
johannes
On Mon, Dec 17, 2007 at 10:56:14AM +0100, Mattias Nissler wrote:
>
> On Mon, 2007-12-17 at 02:09 +0100, Johannes Berg wrote:
> > > That was my original proposal, but during a recent discussion John
> > > suggested not to remove rc80211-simple right now, as it's currently
> > > almost working for a lot of people. John, any suggestions?
> >
> > Those people can fix the bitrate at 1M if the pid algorithm becomes
> > problematic, that's what simple currently does in practice.
>
> Agreed. So what flavour of this patch do you want? John?
My "Spidey sense" tells me it would be good to keep the old one around
for a little while... :-)
Besides, as we have seen recently people often get quite upset when
you remove a feature that they perceive to be working for them --
no matter how much better the alternative may be. It would be better
to give them some warning.
John
--
John W. Linville
[email protected]
> > > +What: rc80211-simple rate control algorithm for mac80211
> > > +When: 2.6.26
> > > +Files: net/mac80211/rc80211-simple.c
> > > +Why: This algorithm was provided for reference but always exhibited bad
> > > + responsiveness and performance and has some serious flaws. It has been
> > > + replaced by rc80211-pid.
> > > +Who: Stefano Brivio <[email protected]>
> >
> > I don't think we really want to do this. We can't even change the
> > algorithm anyway except by recompiling with a different default.
>
> What do you suggest instead?
Just kick it out right away.
johannes
On Mon, 2007-12-17 at 01:50 +0100, Stefano Brivio wrote:
> On Mon, 17 Dec 2007 01:49:06 +0100
> Johannes Berg <[email protected]> wrote:
>
> > > -What: iee80211 softmac wireless networking component
> > > +What: ieee80211 softmac wireless networking component
> >
> >
> > Unrelated change, please separate.
>
> Will do.
Done so :-)
> That was my original proposal, but during a recent discussion John
> suggested not to remove rc80211-simple right now, as it's currently
> almost working for a lot of people. John, any suggestions?
Those people can fix the bitrate at 1M if the pid algorithm becomes
problematic, that's what simple currently does in practice.
johannes
On Mon, 2007-12-17 at 02:09 +0100, Johannes Berg wrote:
> > That was my original proposal, but during a recent discussion John
> > suggested not to remove rc80211-simple right now, as it's currently
> > almost working for a lot of people. John, any suggestions?
>
> Those people can fix the bitrate at 1M if the pid algorithm becomes
> problematic, that's what simple currently does in practice.
Agreed. So what flavour of this patch do you want? John?
Mattias
On Mon, 17 Dec 2007 01:54:33 +0100
Johannes Berg <[email protected]> wrote:
>
> > > > +What: rc80211-simple rate control algorithm for mac80211
> > > > +When: 2.6.26
> > > > +Files: net/mac80211/rc80211-simple.c
> > > > +Why: This algorithm was provided for reference but always exhibited bad
> > > > + responsiveness and performance and has some serious flaws. It has been
> > > > + replaced by rc80211-pid.
> > > > +Who: Stefano Brivio <[email protected]>
> > >
> > > I don't think we really want to do this. We can't even change the
> > > algorithm anyway except by recompiling with a different default.
> >
> > What do you suggest instead?
>
> Just kick it out right away.
That was my original proposal, but during a recent discussion John
suggested not to remove rc80211-simple right now, as it's currently
almost working for a lot of people. John, any suggestions?
--
Ciao
Stefano
On Mon, 17 Dec 2007 01:49:06 +0100
Johannes Berg <[email protected]> wrote:
> > -What: iee80211 softmac wireless networking component
> > +What: ieee80211 softmac wireless networking component
>
>
> Unrelated change, please separate.
Will do.
> > +
> > +What: rc80211-simple rate control algorithm for mac80211
> > +When: 2.6.26
> > +Files: net/mac80211/rc80211-simple.c
> > +Why: This algorithm was provided for reference but always exhibited bad
> > + responsiveness and performance and has some serious flaws. It has been
> > + replaced by rc80211-pid.
> > +Who: Stefano Brivio <[email protected]>
>
> I don't think we really want to do this. We can't even change the
> algorithm anyway except by recompiling with a different default.
What do you suggest instead?
--
Ciao
Stefano
> My "Spidey sense" tells me it would be good to keep the old one around
> for a little while... :-)
>
> Besides, as we have seen recently people often get quite upset when
> you remove a feature that they perceive to be working for them --
> no matter how much better the alternative may be. It would be better
> to give them some warning.
Then we need to introduce a Kconfig option for making the simple one
default because we don't have run-time switching yet.
johannes