2010-09-15 19:29:45

by John W. Linville

Subject: [PATCH] ath9k: make ath_ant_div_conf_fast_divbias static

CHECK drivers/net/wireless/ath/ath9k/recv.c
drivers/net/wireless/ath/ath9k/recv.c:1341:6: warning: symbol 'ath_ant_div_conf_fast_divbias' was not declared. Should it be static?

Signed-off-by: John W. Linville <[email protected]>
---
drivers/net/wireless/ath/ath9k/recv.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
index 6fb3b45..aa9a14d 100644
--- a/drivers/net/wireless/ath/ath9k/recv.c
+++ b/drivers/net/wireless/ath/ath9k/recv.c
@@ -1338,7 +1338,7 @@ static void ath_select_ant_div_from_quick_scan(struct ath_ant_comb *antcomb,
}
}

-void ath_ant_div_conf_fast_divbias(struct ath_hw_antcomb_conf *ant_conf)
+static void ath_ant_div_conf_fast_divbias(struct ath_hw_antcomb_conf *ant_conf)
{
/* Adjust the fast_div_bias based on main and alt lna conf */
switch ((ant_conf->main_lna_conf << 4) | ant_conf->alt_lna_conf) {
--
1.7.2.3

2010-09-16 04:57:11

by Vasanthakumar Thiagarajan

Subject: Re: [PATCH] ath9k: make ath_ant_div_conf_fast_divbias static

On Thu, Sep 16, 2010 at 12:56:13AM +0530, John W. Linville wrote:
> CHECK drivers/net/wireless/ath/ath9k/recv.c
> drivers/net/wireless/ath/ath9k/recv.c:1341:6: warning: symbol 'ath_ant_div_conf_fast_divbias' was not declared. Should it be static?
>
> Signed-off-by: John W. Linville <[email protected]>
> ---
> drivers/net/wireless/ath/ath9k/recv.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
> index 6fb3b45..aa9a14d 100644
> --- a/drivers/net/wireless/ath/ath9k/recv.c
> +++ b/drivers/net/wireless/ath/ath9k/recv.c
> @@ -1338,7 +1338,7 @@ static void ath_select_ant_div_from_quick_scan(struct ath_ant_comb *antcomb,
> }
> }
>
> -void ath_ant_div_conf_fast_divbias(struct ath_hw_antcomb_conf *ant_conf)
> +static void ath_ant_div_conf_fast_divbias(struct ath_hw_antcomb_conf *ant_conf)
> {
> /* Adjust the fast_div_bias based on main and alt lna conf */
> switch ((ant_conf->main_lna_conf << 4) | ant_conf->alt_lna_conf) {

thanks for fixing this. btw, a patch fixing this one was already
part of my 3 patch series, probably the commit log was not good
or something?

Thanks,

Vasanth